From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 1/2] drm/i915: allow userspace forcewake references also on gen7
Date: Tue, 24 Jan 2012 12:04:31 +0100 [thread overview]
Message-ID: <20120124110431.GC3980@phenom.ffwll.local> (raw)
In-Reply-To: <e39f63$3e5jo4@fmsmga002.fm.intel.com>
On Tue, Jan 24, 2012 at 10:35:04AM +0000, Chris Wilson wrote:
> On Tue, 24 Jan 2012 09:44:28 +0100, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> > We need this to correctly access registers in the gt power well from
> > userspace.
>
> How about a INTEL_INFO(dev)->has_forcewake or check for the
> ->forcewake_get? That would be more self-documenting, and we are less
> likely to miss one in the future, than adding more random generation
> checks.
I'll jot down a todo to create a cleanup patch for -next that introduce
some feature flags like has_forcewake has_rc6 and such to avoid such
gaffles (hopefully).
-Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
next prev parent reply other threads:[~2012-01-24 11:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-24 8:44 [PATCH 1/2] drm/i915: allow userspace forcewake references also on gen7 Daniel Vetter
2012-01-24 8:44 ` [PATCH 2/2] drm/i915: debugfs: show semaphore registers " Daniel Vetter
2012-01-24 14:45 ` Eugeni Dodonov
2012-01-24 19:08 ` Keith Packard
2012-01-24 21:32 ` Keith Packard
2012-01-24 10:35 ` [PATCH 1/2] drm/i915: allow userspace forcewake references " Chris Wilson
2012-01-24 11:04 ` Daniel Vetter [this message]
2012-01-24 14:47 ` Eugeni Dodonov
2012-01-24 14:46 ` Eugeni Dodonov
2012-01-24 19:08 ` Keith Packard
2012-01-24 21:31 ` Keith Packard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120124110431.GC3980@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.