From: Andrew Morton <akpm@linux-foundation.org>
To: Cyrill Gorcunov <gorcunov@gmail.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
KOSAKI Motohiro <kosaki.motohiro@gmail.com>,
"H. Peter Anvin" <hpa@zytor.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
linux-kernel@vger.kernel.org,
Pavel Emelyanov <xemul@parallels.com>,
Serge Hallyn <serge.hallyn@canonical.com>,
Kees Cook <keescook@chromium.org>, Tejun Heo <tj@kernel.org>,
Andrew Vagin <avagin@openvz.org>,
Alexey Dobriyan <adobriyan@gmail.com>,
Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
Glauber Costa <glommer@parallels.com>,
Andi Kleen <andi@firstfloor.org>,
Matt Helsley <matthltc@us.ibm.com>,
Pekka Enberg <penberg@kernel.org>,
Eric Dumazet <eric.dumazet@gmail.com>,
Vasiliy Kulikov <segoon@openwall.com>,
Valdis.Kletnieks@vt.edu
Subject: Re: [patch 2/4] [RFC] syscalls, x86: Add __NR_kcmp syscall v4
Date: Tue, 24 Jan 2012 13:45:10 -0800 [thread overview]
Message-ID: <20120124134510.75f2c63f.akpm@linux-foundation.org> (raw)
In-Reply-To: <20120124132222.d78bc0d4.akpm@linux-foundation.org>
On Tue, 24 Jan 2012 13:22:22 -0800
Andrew Morton <akpm@linux-foundation.org> wrote:
> static int kcmp_task_pointers(void *task1, void *task2, size_t field_offset,
> enum you_forgot_to_name_the_enum type)
> {
> void **field1 = t1 + field_offset; /* points to a pointer in the task_struct */
> void **field2 = t1 + field_offset;
On reflection, this was being too cute. It would be better to make the
function type-safer and just put up with the local typecasts:
static int kcmp_task_pointers(struct task_struct *task1,
struct task_struct *task2, size_t field_offset,
enum you_forgot_to_name_the_enum type)
{
void **field1 = (void *)t1 + field_offset;
void **field2 = (void *)t2 + field_offset;
next prev parent reply other threads:[~2012-01-24 21:45 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-23 14:20 [patch 0/4] A few patches in a sake of c/r functionality Cyrill Gorcunov
2012-01-23 14:20 ` [patch 1/4] fs, proc: Introduce /proc/<pid>/task/<tid>/children entry v8 Cyrill Gorcunov
2012-01-23 18:54 ` Kees Cook
2012-01-23 19:33 ` Cyrill Gorcunov
2012-01-23 20:29 ` Kees Cook
2012-01-23 20:39 ` Cyrill Gorcunov
2012-01-24 2:07 ` KAMEZAWA Hiroyuki
2012-01-24 6:53 ` Cyrill Gorcunov
2012-01-24 7:07 ` KAMEZAWA Hiroyuki
2012-01-24 7:21 ` Cyrill Gorcunov
2012-01-24 8:52 ` Eric W. Biederman
2012-01-24 9:11 ` Cyrill Gorcunov
2012-01-25 1:14 ` KOSAKI Motohiro
2012-01-25 2:11 ` Eric W. Biederman
2012-01-25 6:55 ` Cyrill Gorcunov
2012-01-25 15:29 ` Cyrill Gorcunov
2012-01-24 8:51 ` Cyrill Gorcunov
2012-01-24 23:53 ` Andrew Morton
2012-01-25 6:52 ` Cyrill Gorcunov
2012-01-23 14:20 ` [patch 2/4] [RFC] syscalls, x86: Add __NR_kcmp syscall v4 Cyrill Gorcunov
2012-01-23 18:48 ` H. Peter Anvin
2012-01-23 20:03 ` Cyrill Gorcunov
2012-01-24 2:16 ` KAMEZAWA Hiroyuki
2012-01-24 6:47 ` Cyrill Gorcunov
2012-01-24 7:04 ` H. Peter Anvin
2012-01-24 7:17 ` Cyrill Gorcunov
2012-01-24 7:20 ` KAMEZAWA Hiroyuki
2012-01-24 7:38 ` Cyrill Gorcunov
2012-01-24 7:40 ` KAMEZAWA Hiroyuki
2012-01-24 8:48 ` Cyrill Gorcunov
2012-01-24 20:20 ` KOSAKI Motohiro
2012-01-24 20:26 ` Cyrill Gorcunov
2012-01-24 20:44 ` Eric W. Biederman
2012-01-24 20:50 ` Cyrill Gorcunov
2012-01-24 21:20 ` Eric W. Biederman
2012-01-24 21:34 ` Cyrill Gorcunov
2012-01-24 21:22 ` Andrew Morton
2012-01-24 21:45 ` Andrew Morton [this message]
2012-01-24 21:46 ` H. Peter Anvin
2012-01-24 22:00 ` Andrew Morton
2012-01-24 22:52 ` H. Peter Anvin
2012-01-24 23:42 ` Andrew Morton
2012-01-24 21:46 ` Cyrill Gorcunov
2012-01-24 21:59 ` Andrew Morton
2012-01-24 22:54 ` Eric W. Biederman
2012-01-24 22:54 ` Andrew Morton
2012-01-24 21:25 ` Andrew Morton
2012-01-24 21:31 ` Cyrill Gorcunov
2012-01-24 8:49 ` Eric W. Biederman
2012-01-24 8:49 ` Cyrill Gorcunov
2012-01-23 14:20 ` [patch 3/4] c/r: procfs: add arg_start/end, env_start/end and exit_code members to /proc/$pid/stat Cyrill Gorcunov
2012-01-23 20:42 ` Kees Cook
2012-01-23 20:53 ` Cyrill Gorcunov
2012-01-24 23:59 ` Andrew Morton
2012-01-25 6:54 ` Cyrill Gorcunov
2012-01-25 7:12 ` Andrew Morton
2012-01-25 7:18 ` Cyrill Gorcunov
2012-01-23 14:20 ` [patch 4/4] c/r: prctl: Extend PR_SET_MM to set up more mm_struct entries Cyrill Gorcunov
2012-01-23 15:55 ` Cyrill Gorcunov
2012-01-23 20:02 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120124134510.75f2c63f.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=Valdis.Kletnieks@vt.edu \
--cc=adobriyan@gmail.com \
--cc=andi@firstfloor.org \
--cc=avagin@openvz.org \
--cc=ebiederm@xmission.com \
--cc=eric.dumazet@gmail.com \
--cc=glommer@parallels.com \
--cc=gorcunov@gmail.com \
--cc=hpa@zytor.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=keescook@chromium.org \
--cc=kosaki.motohiro@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthltc@us.ibm.com \
--cc=mingo@elte.hu \
--cc=penberg@kernel.org \
--cc=segoon@openwall.com \
--cc=serge.hallyn@canonical.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.