From: Christoph Hellwig <hch@infradead.org>
To: Chandra Seetharaman <sekharan@us.ibm.com>
Cc: xfs@oss.sgi.com
Subject: Re: [RFC PATCH 2/4] Define a new function xfs_inode_dquot()
Date: Tue, 24 Jan 2012 12:48:50 -0500 [thread overview]
Message-ID: <20120124174850.GE9853@infradead.org> (raw)
In-Reply-To: <20120123173130.31546.80744.sendpatchset@chandra-lucid.austin.ibm.com>
On Mon, Jan 23, 2012 at 11:31:30AM -0600, Chandra Seetharaman wrote:
> Define a new function xfs_inode_dquot() that takes a inode pointer
> and a disk quota type and returns the quota pointer for the specified
> quota type.
>
> This simplifies the xfs_qm_dqget() error path significantly.
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
> +static inline xfs_dquot_t *xfs_inode_dquot(struct xfs_inode *ip, int type)
> +{
> + type &= XFS_DQ_ALLTYPES;
> + switch(type) {
Same style nitpick as for the last patch.
Btw, instead of masking out XFS_DQ_ALLTYPES first this would be more
readable as:
switch (type & XFS_DQ_ALLTYPES) {
(that also applies to the previous patch).
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-01-24 17:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-23 17:31 [RFC PATCH 0/4] Rearrange code to make the code more readable Chandra Seetharaman
2012-01-23 17:31 ` [RFC PATCH 1/4] Define a new function xfs_this_quota_on() Chandra Seetharaman
2012-01-24 17:47 ` Christoph Hellwig
2012-02-03 15:19 ` Ben Myers
2012-01-23 17:31 ` [RFC PATCH 2/4] Define a new function xfs_inode_dquot() Chandra Seetharaman
2012-01-24 17:48 ` Christoph Hellwig [this message]
2012-01-24 19:41 ` Chandra Seetharaman
2012-02-03 16:21 ` Ben Myers
2012-01-23 17:31 ` [RFC PATCH 3/4] Change xfs_sb_from_disk() interface to take a mount pointer Chandra Seetharaman
2012-01-24 17:52 ` Christoph Hellwig
2012-02-03 17:02 ` Ben Myers
2012-01-23 17:31 ` [RFC PATCH 4/4] Define new macro XFS_ALL_QUOTA_ACTIVE and simply some usage Chandra Seetharaman
2012-01-24 17:53 ` Christoph Hellwig
2012-02-03 17:16 ` Ben Myers
-- strict thread matches above, loose matches on Subject: below --
2011-10-27 22:05 [RFC PATCH 0/4] Rearrange code to make the code more readable Chandra Seetharaman
2011-10-27 22:05 ` [RFC PATCH 2/4] Define a new function xfs_inode_dquot() Chandra Seetharaman
2011-11-11 20:29 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120124174850.GE9853@infradead.org \
--to=hch@infradead.org \
--cc=sekharan@us.ibm.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.