From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 3/8] sandbox: gpio: Add basic driver for simulating GPIOs
Date: Tue, 24 Jan 2012 18:06:40 -0500 [thread overview]
Message-ID: <201201241806.41119.vapier@gentoo.org> (raw)
In-Reply-To: <201201241635.01261.vapier@gentoo.org>
On Tuesday 24 January 2012 16:35:00 Mike Frysinger wrote:
> On Monday 23 January 2012 01:20:16 Simon Glass wrote:
> > On Fri, Jan 20, 2012 at 10:59 AM, Mike Frysinger wrote:
> > > On Tuesday 10 January 2012 19:45:47 Simon Glass wrote:
> > >> --- /dev/null
> > >> +++ b/arch/sandbox/include/asm/gpio.h
> > >>
> > >> +int sandbox_gpio_get_value(int gp);
> > >
> > > why bother with parallel sandbox gpio API ? why can't we just
> > > implement the gpio API directly and throw away sandbox_gpio_xxx ?
> > > then we can also stub out sandbox/include/asm/gpio.h ...
> >
> > Because the current state of the GPIOs needs to be stored somewhere.
> > Test code which wants a GPIO to appear to be high to U-Boot can call
> > sandbox_gpio_set_value() and that value will be recorded and provided
> > to future gpio_get_value() calls.
> >
> > Without this virtualisation, the driver would have no purpose.
>
> i'm not seeing it. why does external code need to reach into the guts at
> all when we have a gpio API for them to use ?
ok, you clarified it for me, so now we just need some comments in asm/gpio.h
explaining the expected users of the internal API
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120124/ee78d5d2/attachment.pgp>
next prev parent reply other threads:[~2012-01-24 23:06 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-11 0:45 [U-Boot] [PATCH v2 1/8] sandbox: fdt: Add support for CONFIG_OF_CONTROL Simon Glass
2012-01-11 0:45 ` [U-Boot] [PATCH v2 2/8] sandbox: config: Enable fdt and snprintf() options Simon Glass
2012-01-20 18:54 ` Mike Frysinger
2012-01-23 5:30 ` Simon Glass
2012-01-24 21:24 ` Mike Frysinger
2012-02-15 6:26 ` Simon Glass
2012-02-21 5:24 ` Mike Frysinger
2012-02-21 5:37 ` Simon Glass
2012-02-21 6:12 ` Mike Frysinger
2012-01-11 0:45 ` [U-Boot] [PATCH v2 3/8] sandbox: gpio: Add basic driver for simulating GPIOs Simon Glass
2012-01-20 18:59 ` Mike Frysinger
2012-01-23 6:20 ` Simon Glass
2012-01-24 21:35 ` Mike Frysinger
2012-01-24 23:06 ` Mike Frysinger [this message]
2012-02-15 22:34 ` Simon Glass
2012-01-11 0:45 ` [U-Boot] [PATCH v2 4/8] sandbox: Enable GPIO driver Simon Glass
2012-01-20 18:59 ` Mike Frysinger
2012-01-23 6:21 ` Simon Glass
2012-01-11 0:45 ` [U-Boot] [PATCH v2 5/8] sandbox: Add concept of sandbox state Simon Glass
2012-01-11 0:45 ` [U-Boot] [PATCH v2 6/8] sandbox: Allow processing instead of or before main loop Simon Glass
2012-01-20 19:00 ` Mike Frysinger
2012-01-23 6:25 ` Simon Glass
2012-01-11 0:45 ` [U-Boot] [PATCH v2 7/8] sandbox: Add flags for open() call Simon Glass
2012-01-15 4:19 ` Mike Frysinger
2012-01-15 4:36 ` Simon Glass
2012-01-15 4:44 ` Mike Frysinger
2012-01-15 4:48 ` Simon Glass
2012-01-11 0:45 ` [U-Boot] [PATCH v2 8/8] sandbox: Add basic command line parsing Simon Glass
2012-01-20 19:05 ` Mike Frysinger
2012-01-23 6:30 ` Simon Glass
2012-01-24 21:36 ` Mike Frysinger
2012-01-20 18:54 ` [U-Boot] [PATCH v2 1/8] sandbox: fdt: Add support for CONFIG_OF_CONTROL Mike Frysinger
2012-01-23 5:27 ` Simon Glass
2012-01-23 7:32 ` Mike Frysinger
2012-02-15 6:11 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201201241806.41119.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.