From: Alessandro Rubini <rubini@gnudd.com>
To: davem@davemloft.net
Cc: linux-kernel@vger.kernel.org, peppe.cavallaro@st.com,
netdev@vger.kernel.org, giancarlo.asnaghi@st.com
Subject: Re: [PATCH 0/3] stmmac patches
Date: Tue, 24 Jan 2012 21:47:10 +0100 [thread overview]
Message-ID: <20120124204710.GA29113@mail.gnudd.com> (raw)
In-Reply-To: <20120124.154311.1857537203481263793.davem@davemloft.net>
>> The second patch is a cleanup, already acked by both authors.
>
> I'm not applying this, instead if you want to make changes in this
> area then fix this driver so that it can properly support multiple
> device instances.
Ok, I'll do, but not soon.
> I can't even imagine ever writing a driver where from the start
> it can handle only one device instance, this is pure insanity
> especially for a PCI device driver.
I agree. But it _already_ is like this. I just want the fact to be
clear, so when somebody burns two macs in the fpga it will complain
instead of breaking. That said, I have no problem if you still
refuse it.
> You're breaking things for anyone using 'stmmaceth='. So I'm not
> applying this patch either.
Fine with me.
thanks
/alessandro
prev parent reply other threads:[~2012-01-24 20:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-24 9:08 [PATCH 0/3] stmmac patches Alessandro Rubini
2012-01-24 9:08 ` [PATCH 1/3] stmmac: added PCI identifiers Alessandro Rubini
2012-01-24 9:09 ` [PATCH 2/3] stmmac: err out on second probe; use precompiled static structures Alessandro Rubini
2012-01-24 9:09 ` [PATCH 3/3] stmmac: remove kernel cmdline parsing Alessandro Rubini
2012-01-24 20:43 ` [PATCH 0/3] stmmac patches David Miller
2012-01-24 20:47 ` Alessandro Rubini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120124204710.GA29113@mail.gnudd.com \
--to=rubini@gnudd.com \
--cc=davem@davemloft.net \
--cc=giancarlo.asnaghi@st.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.