From: Greg KH <greg@kroah.com>
To: Jason Baron <jbaron@redhat.com>
Cc: Bart Van Assche <bvanassche@acm.org>,
Jim Cromie <jim.cromie@gmail.com>,
joe@perches.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 15/16] dynamic_debug: factor vpr_info_dq out of ddebug_parse_query
Date: Tue, 24 Jan 2012 12:50:10 -0800 [thread overview]
Message-ID: <20120124205010.GA12455@kroah.com> (raw)
In-Reply-To: <20111221213341.GC30393@redhat.com>
On Wed, Dec 21, 2011 at 04:33:42PM -0500, Jason Baron wrote:
> On Tue, Dec 20, 2011 at 03:49:54PM +0000, Bart Van Assche wrote:
> > On Tue, Dec 20, 2011 at 3:47 PM, Jim Cromie <jim.cromie@gmail.com> wrote:
> > > On Tue, Dec 20, 2011 at 1:17 AM, Bart Van Assche <bvanassche@acm.org> wrote:
> > > > On Mon, Dec 19, 2011 at 10:13 PM, Jason Baron <jbaron@redhat.com> wrote:
> > > >> From: Jim Cromie <jim.cromie@gmail.com>
> > > >>
> > > >> Factor pr_info(query) out of ddebug_parse_query, into pr_info_dq(),
> > > >> for reuse later. Also change the printed labels: file, func to agree
> > > >> with the query-spec keywords accepted in the control file. Pass ""
> > > >> when string is null, to avoid "(null)" output from sprintf. For
> > > >> format print, use precision to skip last char, assuming its '\n', no
> > > >> great harm if not, its a debug msg.
> > > >
> > > > pr_info_dq() or vpr_info_dq() ?
> > >
> > > I chose vpr_info_dq, with leading v to hint at the "if (verbose)" part
> >
> > In case my reply was a little too terse: isn't there a letter "v"
> > missing in the commit message ?
> >
> > Bart.
>
> Thanks for catching this.
>
> Greg, if you want to s/pr_info_dq/vpr_info_dq, in the commit msg, this
> one is all set.
Now done, thanks.
greg k-h
next prev parent reply other threads:[~2012-01-24 20:51 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-19 22:11 [PATCH 00/16] dynamic debug: ehancements and cleanups Jason Baron
2011-12-19 22:11 ` [PATCH 01/16] dynamic_debug: fix whitespace complaints from scripts/cleanfile Jason Baron
2011-12-19 22:11 ` [PATCH 02/16] dynamic_debug: drop enabled field from struct _ddebug, use _DPRINTK_FLAGS_PRINT Jason Baron
2011-12-19 22:11 ` [PATCH 03/16] dynamic_debug: make dynamic-debug supersede DEBUG ccflag Jason Baron
2011-12-19 22:12 ` [PATCH 04/16] dynamic_debug: change verbosity at runtime Jason Baron
2011-12-19 22:12 ` [PATCH 05/16] dynamic_debug: replace strcpy with strlcpy, in ddebug_setup_query() Jason Baron
2011-12-20 8:08 ` Bart Van Assche
2011-12-21 21:30 ` Jason Baron
2011-12-19 22:12 ` [PATCH 06/16] dynamic_debug: pr_err() call should not depend upon verbosity Jason Baron
2011-12-19 22:12 ` [PATCH 07/16] dynamic_debug: drop explicit !=NULL checks Jason Baron
2011-12-19 22:12 ` [PATCH 08/16] dynamic_debug: describe_flags with '=[pmflt_]*' Jason Baron
2011-12-19 22:12 ` [PATCH 09/16] dynamic_debug: tighten up error checking on debug queries Jason Baron
2011-12-19 22:12 ` [PATCH 10/16] dynamic_debug: early return if _ddebug table is empty Jason Baron
2011-12-19 22:12 ` [PATCH 11/16] dynamic_debug: reduce lineno field to a saner 18 bits Jason Baron
2011-12-19 22:13 ` [PATCH 12/16] dynamic_debug: chop off comments in ddebug_tokenize Jason Baron
2011-12-19 22:13 ` [PATCH 13/16] dynamic_debug: enlarge command/query write buffer Jason Baron
2011-12-19 22:13 ` [PATCH 14/16] dynamic_debug: add trim_prefix() to provide source-root relative paths Jason Baron
2011-12-20 8:15 ` Bart Van Assche
2011-12-21 21:32 ` Jason Baron
2011-12-19 22:13 ` [PATCH 15/16] dynamic_debug: factor vpr_info_dq out of ddebug_parse_query Jason Baron
2011-12-20 8:17 ` Bart Van Assche
2011-12-20 15:47 ` Jim Cromie
2011-12-20 15:49 ` Bart Van Assche
2011-12-21 21:33 ` Jason Baron
2012-01-24 20:50 ` Greg KH [this message]
2011-12-19 22:13 ` [PATCH 16/16] dynamic_debug: process multiple debug-queries on a line Jason Baron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120124205010.GA12455@kroah.com \
--to=greg@kroah.com \
--cc=bvanassche@acm.org \
--cc=jbaron@redhat.com \
--cc=jim.cromie@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.