From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Serge E. Hallyn" Subject: Re: [RFC] fix devpts mount behavior Date: Tue, 24 Jan 2012 23:29:54 +0000 Message-ID: <20120124232954.GA26607@hallyn.com> References: <20120124000517.GA28878@sergelap> <20120124002555.GA29534@sergelap> <20120124010758.GJ23916@ZenIV.linux.org.uk> <20120124220247.GA26353@hallyn.com> <20120124231601.GA4470@sergelap> <20120124232502.GA22218@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20120124232502.GA22218-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Sukadev Bhattiprolu Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Kay Sievers , Dave Hansen , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "Eric W. Biederman" , Andy Whitcroft , Linus Torvalds , Al Viro List-Id: containers.vger.kernel.org Quoting Sukadev Bhattiprolu (sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org): > Serge Hallyn [serge.hallyn-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org] wrote: > | > | That has nothing to do with /dev/pts/ptmx, whose perms are set based on > | the '-o ptmxmode=" argument, and default to 000 if not specified. If > | /dev/ptmx is going to be a symlink to /dev/pts/ptmx, then we have to set > | the /dev/pts/ptmx perms to not be 000, or users won't be able to create > | ptys. > > If we are going to make 'newinstance' the default, maybe the default > ptmx mode could be changed to 0666 in the kernel too ? > Right that was what i meant :) thanks, -serge From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753393Ab2AXX2Q (ORCPT ); Tue, 24 Jan 2012 18:28:16 -0500 Received: from 50-56-35-84.static.cloud-ips.com ([50.56.35.84]:49055 "EHLO mail.hallyn.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752940Ab2AXX2O (ORCPT ); Tue, 24 Jan 2012 18:28:14 -0500 Date: Tue, 24 Jan 2012 23:29:54 +0000 From: "Serge E. Hallyn" To: Sukadev Bhattiprolu Cc: Serge Hallyn , Kay Sievers , containers@lists.linux-foundation.org, Dave Hansen , linux-kernel@vger.kernel.org, "Eric W. Biederman" , Andy Whitcroft , Linus Torvalds , Al Viro Subject: Re: [RFC] fix devpts mount behavior Message-ID: <20120124232954.GA26607@hallyn.com> References: <20120124000517.GA28878@sergelap> <20120124002555.GA29534@sergelap> <20120124010758.GJ23916@ZenIV.linux.org.uk> <20120124220247.GA26353@hallyn.com> <20120124231601.GA4470@sergelap> <20120124232502.GA22218@us.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120124232502.GA22218@us.ibm.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Sukadev Bhattiprolu (sukadev@linux.vnet.ibm.com): > Serge Hallyn [serge.hallyn@canonical.com] wrote: > | > | That has nothing to do with /dev/pts/ptmx, whose perms are set based on > | the '-o ptmxmode=" argument, and default to 000 if not specified. If > | /dev/ptmx is going to be a symlink to /dev/pts/ptmx, then we have to set > | the /dev/pts/ptmx perms to not be 000, or users won't be able to create > | ptys. > > If we are going to make 'newinstance' the default, maybe the default > ptmx mode could be changed to 0666 in the kernel too ? > Right that was what i meant :) thanks, -serge