From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Karol Lewandowski <k.lewandowsk@samsung.com>
Cc: linux-kernel@vger.kernel.org, m.szyprowski@samsung.com,
s.nawrocki@samsung.com, lrg@ti.com,
Kyungmin Park <kyungmin.park@samsung.com>,
Thomas Abraham <thomas.abraham@linaro.org>
Subject: Re: [PATCH] regulator: Set apply_uV only when min and max voltages are defined
Date: Wed, 25 Jan 2012 11:39:41 +0000 [thread overview]
Message-ID: <20120125113940.GD3687@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1327483905-27007-1-git-send-email-k.lewandowsk@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 441 bytes --]
On Wed, Jan 25, 2012 at 10:31:45AM +0100, Karol Lewandowski wrote:
> apply_uV is errornously set when regulator is instantiated from device
> tree, even when it doesn't contain any voltage constraints.
Applied, thanks. But really
> - if (constraints->min_uV == constraints->max_uV)
> + if (min_uV && max_uV && constraints->min_uV == constraints->max_uV)
we only actually need to check one of min_uV and max_uV due to the
equality check.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-01-25 11:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-25 9:31 [PATCH] regulator: Set apply_uV only when min and max voltages are defined Karol Lewandowski
2012-01-25 10:15 ` Karol Lewandowski
2012-01-25 10:33 ` Karol Lewandowski
2012-01-25 11:22 ` Mark Brown
2012-01-25 11:39 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120125113940.GD3687@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=k.lewandowsk@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=m.szyprowski@samsung.com \
--cc=s.nawrocki@samsung.com \
--cc=thomas.abraham@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.