From: Greg KH <gregkh@suse.de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Greg KH <greg@kroah.com>,
linux-kernel@vger.kernel.org, Alan Cox <alan@linux.intel.com>,
kernel@pengutronix.de, devicetree-discuss@lists.ozlabs.org,
linux-serial@vger.kernel.org
Subject: Re: [PATCH v4] serial/efm32: add new driver
Date: Wed, 25 Jan 2012 07:52:58 -0800 [thread overview]
Message-ID: <20120125155258.GB3608@suse.de> (raw)
In-Reply-To: <1327478704-4233-1-git-send-email-u.kleine-koenig@pengutronix.de>
On Wed, Jan 25, 2012 at 09:05:04AM +0100, Uwe Kleine-König wrote:
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> changes since v3 (id:1326127447-20284-1-git-send-email-u.kleine-koenig@pengutronix.de)
> - increase number of ports to support UART additionally to USART ports
> - implement choosing route location
> - implement setting stopbit config
> (before one stop bit was configured and CSTOPB was set unconditionally which
> is wrong. Spotted by Russell King.)
> - implement break, sysrq and overflow detection
> - drop unrelated changing to make patch apply on v3.3-rc1
>
> Hello Greg,
>
> On Tue, Jan 24, 2012 at 02:05:22PM -0800, Greg KH wrote:
> > On Mon, Jan 09, 2012 at 05:44:07PM +0100, Uwe Kleine-König wrote:
> > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > > ---
> > > Hello,
> > >
> > > changes since v2:
> > > - use {read,write}l_relaxed
> > > - rename driver to efm32-uart as USARTs and UARTs can be handled both
> > > with it
> > > - disable TX in .stop_tx (which needs some changes related to
> > > USARTn_IF_TXC)
> > >
> > > Best regards
> > > Uwe
> > >
> > > .../devicetree/bindings/tty/serial/efm32-uart.txt | 14 +
> > > arch/arm/boot/dts/efm32gg-dk3750.dts | 2 +-
> > > arch/arm/mach-efm32/devices/pdev-efm32-usart.c | 6 +-
> >
> > This file isn't in 3.3-rc1, so I can't apply this patch :(
> >
> > What tree is it supposed to be against?
> Sorry, I messed this up, it bases on my private development tree. These
> two changes should go independant of the driver patch via an ARM tree
> (if at all).
>
> I added a few more features in the meantime, so the options are:
> - take v3 simply droping the hunks changing
> arch/arm/boot/dts/efm32gg-dk3750.dts and
> arch/arm/mach-efm32/devices/pdev-efm32-usart.c
> - take this for 3.3
> - take this for 3.4
>
> My preference would be of course the second option, but for me the other two
> would be OK if you don't like taking the update that late, too.
I was going to take this for the 3.4 merge, adding it to my tree now.
It should be ok to drop those hunks, right?
greg k-h
next prev parent reply other threads:[~2012-01-25 15:52 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-21 15:05 [PATCH] serial/efm32: add new driver Uwe Kleine-König
2011-12-21 15:05 ` Uwe Kleine-König
2011-12-21 20:28 ` Alan Cox
2011-12-21 20:28 ` Alan Cox
2011-12-22 8:57 ` Uwe Kleine-König
[not found] ` <20111221202847.4ffeba10-Z/y2cZnRghHXmaaqVzeoHQ@public.gmane.org>
2011-12-22 13:38 ` Uwe Kleine-König
2011-12-22 13:38 ` Uwe Kleine-König
2011-12-23 10:35 ` Arnd Bergmann
2011-12-23 10:35 ` Arnd Bergmann
2011-12-23 20:44 ` Uwe Kleine-König
[not found] ` <20111223204428.GI24496-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-01-09 9:59 ` Kconfig option for compile time build coverage (Was: Re: [PATCH] serial/efm32: add new driver) Uwe Kleine-König
2012-01-09 9:59 ` Uwe Kleine-König
2012-01-25 16:16 ` Arnd Bergmann
2012-01-25 16:16 ` Arnd Bergmann
2012-01-09 10:34 ` [PATCH] serial/efm32: add new driver Uwe Kleine-König
2012-01-25 16:56 ` Arnd Bergmann
2012-01-25 16:56 ` Arnd Bergmann
[not found] ` <1324561092-1945-1-git-send-email-u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-01-09 16:44 ` [PATCH v3] " Uwe Kleine-König
2012-01-09 16:44 ` Uwe Kleine-König
2012-01-24 22:05 ` Greg KH
2012-01-24 22:05 ` Greg KH
2012-01-25 8:05 ` [PATCH v4] " Uwe Kleine-König
2012-01-25 8:05 ` Uwe Kleine-König
2012-01-25 8:25 ` Joe Perches
2012-01-25 8:25 ` Joe Perches
2012-01-25 8:41 ` Uwe Kleine-König
2012-01-25 15:52 ` Greg KH [this message]
2012-01-25 18:36 ` Uwe Kleine-König
2012-01-25 18:36 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120125155258.GB3608@suse.de \
--to=gregkh@suse.de \
--cc=alan@linux.intel.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=greg@kroah.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.