Re: [PATCH resend] Clean up new_id and remove_id sysfs attribute routines

[Dominik Brodowski <linux@dominikbrodowski.net>]

On Tue, Jan 24, 2012 at 04:59:36PM -0800, Jesse Barnes wrote:
> On Tue, 24 Jan 2012 16:33:13 -0800
> Greg KH <greg@kroah.com> wrote:
> 
> > On Tue, Jan 24, 2012 at 02:35:13PM -0500, Alan Stern wrote:
> > > This patch (as1514) cleans up some places where new_id and remove_id
> > > sysfs attributes are created and deleted.  Handling both attributes in
> > > a single routine rather than a pair of routines makes the code
> > > smaller.  It also prevents certain kinds of errors, like one we
> > > currently have in the USB subsystem: The removeid attribute is often
> > > created even when newid isn't (because the driver's no_dynamid_id flag
> > > is set).
> > > 
> > > In the case of the PCMCIA subsystem, the newid attribute is created
> > > but never explicitly deleted.  The patch adds a deletion routine.
> > > 
> > > Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
> > > CC: Jesse Barnes <jbarnes@virtuousgeek.org>
> > > CC: Dominik Brodowski <linux@dominikbrodowski.net>
> > 
> > Jesse and Dominik, any objection for me to take this through my tree?
> 
> No objection here, thanks guys.

And none from me, neither. Thanks!

Best,
	Dominik