From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andres Salomon Subject: Re: [PATCH v4 1/1] alix2: supplement driver to include GPIO button support Date: Thu, 26 Jan 2012 17:57:41 -0800 Message-ID: <20120126175741.6aa4a9cd@queued.net> References: <1327627902-18417-1-git-send-email-philipp@redfish-solutions.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from lunge.queued.net ([173.255.254.236]:56876 "EHLO lunge.queued.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751645Ab2A0B5o (ORCPT ); Thu, 26 Jan 2012 20:57:44 -0500 In-Reply-To: <1327627902-18417-1-git-send-email-philipp@redfish-solutions.com> Sender: platform-driver-x86-owner@vger.kernel.org List-ID: To: Philip Prindeville Cc: platform-driver-x86@vger.kernel.org, Alessandro Zummo , Richard Purdie , Ed Wildgoose , David Woodhouse , Andrew Morton On Thu, 26 Jan 2012 18:31:42 -0700 Philip Prindeville wrote: > From: "Philip A. Prindeville" > > GPIO 24 is used in reference designs as a soft-reset button, and > the alix2 is no exception. Add it as a gpio-button. > > Use symbolic values to describe BIOS addresses. > > Record the model number. > > Changes v2 and v3 per Andres: > Use DMI to detect the board instead of proposed coreboot library; > Don't make including conditional on CONFIG_DMI; > Ditto for calling dmi_get_system_info() in alix_present_dmi(); > Make alix_present() and alix_present_dmi() return bool; > > Changes v4 per Andrew: > Remove alix_model as this can be patched downstream where it's needed > anyway (ultimately, RFFILL will be supported by a new generic gpio > class); > > Signed-off-by: Philip A. Prindeville > Acked-by: Ed Wildgoose > Acked-by: Andres Salomon > Cc: Andrew Morton [...] > } > > -static int __init alix_init(void) > +static int __init alix_init(void) What's this about?