From: David Brown <davidb-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
To: Joerg Roedel <joerg.roedel-5C7GfCeVMHo@public.gmane.org>
Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Stepan Moskovchenko
<stepanm-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
Subject: Re: [PATCH] iommu/msm: Fix error handling in msm_iommu_unmap()
Date: Thu, 26 Jan 2012 16:06:30 -0800 [thread overview]
Message-ID: <20120127000630.GB16263@codeaurora.org> (raw)
In-Reply-To: <1327598984-20662-1-git-send-email-joerg.roedel-5C7GfCeVMHo@public.gmane.org>
On Thu, Jan 26, 2012 at 06:29:44PM +0100, Joerg Roedel wrote:
> Error handling in msm_iommu_unmap() is broken. On some error
> conditions retval is set to a non-zero value which causes
> the function to return 'len' at the end. This hides the
> error from the user. Zero should be returned in those error
> cases.
>
> Cc: David Brown <davidb-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
> Cc: Stepan Moskovchenko <stepanm-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
> Signed-off-by: Joerg Roedel <joerg.roedel-5C7GfCeVMHo@public.gmane.org>
> ---
> drivers/iommu/msm_iommu.c | 7 +------
> 1 files changed, 1 insertions(+), 6 deletions(-)
Acked-by: David Brown <davidb-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
WARNING: multiple messages have this Message-ID (diff)
From: David Brown <davidb@codeaurora.org>
To: Joerg Roedel <joerg.roedel@amd.com>
Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
Stepan Moskovchenko <stepanm@codeaurora.org>
Subject: Re: [PATCH] iommu/msm: Fix error handling in msm_iommu_unmap()
Date: Thu, 26 Jan 2012 16:06:30 -0800 [thread overview]
Message-ID: <20120127000630.GB16263@codeaurora.org> (raw)
In-Reply-To: <1327598984-20662-1-git-send-email-joerg.roedel@amd.com>
On Thu, Jan 26, 2012 at 06:29:44PM +0100, Joerg Roedel wrote:
> Error handling in msm_iommu_unmap() is broken. On some error
> conditions retval is set to a non-zero value which causes
> the function to return 'len' at the end. This hides the
> error from the user. Zero should be returned in those error
> cases.
>
> Cc: David Brown <davidb@codeaurora.org>
> Cc: Stepan Moskovchenko <stepanm@codeaurora.org>
> Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
> ---
> drivers/iommu/msm_iommu.c | 7 +------
> 1 files changed, 1 insertions(+), 6 deletions(-)
Acked-by: David Brown <davidb@codeaurora.org>
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
next prev parent reply other threads:[~2012-01-27 0:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-26 17:29 [PATCH] iommu/msm: Fix error handling in msm_iommu_unmap() Joerg Roedel
2012-01-26 17:29 ` Joerg Roedel
[not found] ` <1327598984-20662-1-git-send-email-joerg.roedel-5C7GfCeVMHo@public.gmane.org>
2012-01-27 0:06 ` David Brown [this message]
2012-01-27 0:06 ` David Brown
[not found] ` <20120127000630.GB16263-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2012-01-27 16:40 ` Joerg Roedel
2012-01-27 16:40 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120127000630.GB16263@codeaurora.org \
--to=davidb-sgv2jx0feol9jmxxk+q4oq@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=joerg.roedel-5C7GfCeVMHo@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=stepanm-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.