From: Jean Delvare <khali@linux-fr.org>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH] hwmon: (w83627ehf) Disable setting DC mode for pwm2, pwm3 on NCT6776F
Date: Sat, 28 Jan 2012 08:49:44 +0000 [thread overview]
Message-ID: <20120128094944.5f8bb6fa@endymion.delvare> (raw)
In-Reply-To: <1327715876-3605-1-git-send-email-linux@roeck-us.net>
On Fri, 27 Jan 2012 17:57:56 -0800, Guenter Roeck wrote:
> NCT6776F only supports pwm mode for pwm2 and pwm3. Return error if an attempt
> is made to set those pwm channels to DC mode.
>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/hwmon/w83627ehf.c | 6 ++++++
> 1 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/hwmon/w83627ehf.c b/drivers/hwmon/w83627ehf.c
> index c0ef1a3..4f58202 100644
> --- a/drivers/hwmon/w83627ehf.c
> +++ b/drivers/hwmon/w83627ehf.c
> @@ -1318,6 +1318,7 @@ store_pwm_mode(struct device *dev, struct device_attribute *attr,
> const char *buf, size_t count)
> {
> struct w83627ehf_data *data = dev_get_drvdata(dev);
> + struct w83627ehf_sio_data *sio_data = dev->platform_data;
> struct sensor_device_attribute *sensor_attr = to_sensor_dev_attr(attr);
> int nr = sensor_attr->index;
> unsigned long val;
> @@ -1330,6 +1331,11 @@ store_pwm_mode(struct device *dev, struct device_attribute *attr,
>
> if (val > 1)
> return -EINVAL;
> +
> + /* On NCT67766F, DC mode is only supported for pwm1 */
> + if (sio_data->kind = nct6776 && nr && val != 1)
> + return -EINVAL;
> +
> mutex_lock(&data->update_lock);
> reg = w83627ehf_read_value(data, W83627EHF_REG_PWM_ENABLE[nr]);
> data->pwm_mode[nr] = val;
Good catch. Might even be a candidate for -stable.
Acked-by: Jean Delvare <khali@linux-fr.org>
--
Jean Delvare
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2012-01-28 8:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-28 1:57 [lm-sensors] [PATCH] hwmon: (w83627ehf) Disable setting DC mode for pwm2, pwm3 on NCT6776F Guenter Roeck
2012-01-28 8:49 ` Jean Delvare [this message]
2012-01-28 12:25 ` CC
2012-01-28 12:28 ` CC
2012-01-28 12:56 ` Jean Delvare
2012-01-28 15:34 ` CC
2012-01-28 17:23 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120128094944.5f8bb6fa@endymion.delvare \
--to=khali@linux-fr.org \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.