From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/i915: fixup interlaced bits clearing in
 PIPECONF on PCH_SPLIT
Date: Sat, 28 Jan 2012 12:07:55 +0100
Message-ID: <20120128110755.GA4344@phenom.ffwll.local>
References: <1327594727-6137-1-git-send-email-daniel.vetter@ffwll.ch>
	<1327606970-19326-1-git-send-email-daniel.vetter@ffwll.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com
	[209.85.212.177])
	by gabe.freedesktop.org (Postfix) with ESMTP id 84F7E9E7C8
	for <intel-gfx@lists.freedesktop.org>;
	Sat, 28 Jan 2012 03:07:58 -0800 (PST)
Received: by wico1 with SMTP id o1so2511263wic.36
	for <intel-gfx@lists.freedesktop.org>;
	Sat, 28 Jan 2012 03:07:57 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <1327606970-19326-1-git-send-email-daniel.vetter@ffwll.ch>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Intel Graphics Development <intel-gfx@lists.freedesktop.org>, Keith Packard <keithp@keithp.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
List-Id: intel-gfx@lists.freedesktop.org

On Thu, Jan 26, 2012 at 08:42:50PM +0100, Daniel Vetter wrote:
> An identical patch has been merged for i9xx_crtc_mode_set:
> 
> ommit 59df7b1771c150163e522f33c638096ab0efbf42
> Author: Christian Schmidt <schmidt@digadd.de>
> Date:   Mon Dec 19 20:03:33 2011 +0100
> 
>     drm/intel: Fix initialization if startup happens in interlaced mode [v2]
> 
> But that one neglected to fix up the ironlake+ path.
> 
> This should fix the issue reported by Alfonso Fiore where booting with
> only a HDMI cable connected to his TV failed to display anything. The
> issue is that the bios set up things for 1080i and used the pannel
> fitter to scale up the lower progressive resolutions. We failed to
> clear the interlace bit in the PIPEACONF register, resulting in havoc.
> 
> v2: Be more paranoid and just unconditionally clear the field before
> setting new values.
> 
> Cc: Peter Ross <pross@xvid.org>
> Cc: Alfonso Fiore <alfonso.fiore@gmail.com>
> Signed-Off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

Hi Keith,

Alfonso reported back that this does indeed fix up his "black screen on
boot" issues when the bios sets up the hdmi connector with an interlaced
mode. Can you pick this patch up for -fixes if it musters your review?

Tested-by: Alfonso Fiore <alfonso.fiore@gmail.com>

Thanks, Daniel
-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48