From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Date: Sat, 28 Jan 2012 17:34:34 +0000 Subject: Re: [lm-sensors] [PATCH v2] hwmon/mc13xxx-adc: add support for the MC13892 PMIC Message-Id: <20120128173434.GD3861@ericsson.com> List-Id: References: <1317158169-25372-1-git-send-email-u.kleine-koenig@pengutronix.de> In-Reply-To: <1317158169-25372-1-git-send-email-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: lm-sensors@vger.kernel.org On Fri, Jan 27, 2012 at 04:35:29PM -0500, Jean Delvare wrote: > On Fri, 27 Jan 2012 13:22:08 -0800, Guenter Roeck wrote: > > I have been asked about adding support for ADC channels 0, 1, 3, 4, as > > well as the non-GP usage of channels 5 to 7. > > I'm interested in temperature sensors too, i.e. channels 5 and 7 if I'm > not mistaken. > > > Does anyone happen to know/recall why those are not supported in the > > current driver ? > > No idea, maybe just starting simple, or lack of interest. > Maybe the perceived problem is that gain and offset are different and all over the place for the various ADCs, so one either needs a whole bunch of functions, or a large case statement, or a table with per adc. I'd choose the latter, to simplify runtime code. Also, the description of adc->temperature conversion is really quite confusing. Guenter _______________________________________________ lm-sensors mailing list lm-sensors@lm-sensors.org http://lists.lm-sensors.org/mailman/listinfo/lm-sensors