From: Ingo Molnar <mingo@elte.hu>
To: Michael Wang <wangyun@linux.vnet.ibm.com>
Cc: Cong Wang <xiyou.wangcong@gmail.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Xiaotian Feng <xtfeng@gmail.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] sched: Accelerate "pick_next_entity" under special condition
Date: Sun, 29 Jan 2012 17:33:28 +0100 [thread overview]
Message-ID: <20120129163328.GC23408@elte.hu> (raw)
In-Reply-To: <4F24E804.5090808@linux.vnet.ibm.com>
* Michael Wang <wangyun@linux.vnet.ibm.com> wrote:
> On 01/27/2012 12:42 PM, Cong Wang wrote:
>
> > On 01/27/2012 09:22 AM, Michael Wang wrote:
> >> Hi, Ingo
> >>
> >> Thanks for your reply.
> >>
> >> I have try use "ls -l" to see the size of sched.o, but after applied the
> >> patch, it is still 1636.
> >>
> >> I have not use this method before, may be I use the wrong command...
> >>
> >> But I think the new code should be similar to the old one after compile,
> >> because we still have 3 condition check here.
> >>
> >> I suppose the new sched.o will be a little bigger, because one jump
> >> command and a label need to be added.
> >>
> >
> > Try to see if `size` helps.
>
> Hi, Cong
>
> Thanks for your advise, but still, the size not changed.
>
> And also I don't know whether the size can be some kind of
> proof to confirm the performance improvement in this case...
You could disassemble the .o file via objdump -d and run diff on
it - is there any change in the code generated by GCC?
Thanks,
Ingo
next prev parent reply other threads:[~2012-01-29 16:33 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-16 9:37 [PATCH] sched: Accelerate "pick_next_entity" under special condition Michael Wang
2012-01-16 9:50 ` Michael Wang
2012-01-16 9:51 ` Peter Zijlstra
2012-01-16 10:34 ` Michael Wang
2012-01-17 2:36 ` [PATCH v2] " Michael Wang
2012-01-17 2:41 ` Michael Wang
2012-01-17 2:58 ` Xiaotian Feng
2012-01-17 3:04 ` Michael Wang
2012-01-25 15:55 ` Peter Zijlstra
2012-01-26 10:04 ` Ingo Molnar
2012-01-27 1:22 ` Michael Wang
2012-01-27 4:42 ` Cong Wang
2012-01-29 6:32 ` Michael Wang
2012-01-29 16:33 ` Ingo Molnar [this message]
2012-01-30 3:18 ` Michael Wang
2012-01-30 3:25 ` Cong Wang
2012-01-30 5:47 ` Michael Wang
2012-07-03 6:34 ` [PATCH] sched: remove useless code in yield_to Michael Wang
2012-07-12 5:45 ` Michael Wang
2012-07-12 14:07 ` Peter Zijlstra
2012-07-12 18:44 ` Mike Galbraith
2012-07-16 2:39 ` Michael Wang
2012-08-17 6:56 ` Michael Wang
2012-08-17 9:43 ` Peter Zijlstra
2012-08-10 3:05 ` Michael Wang
2012-08-10 3:10 ` Michael Wang
2012-08-10 5:52 ` Mike Galbraith
2012-09-04 18:50 ` [tip:sched/core] sched: Remove useless code in yield_to() tip-bot for Michael Wang
2012-01-27 0:56 ` [PATCH v2] sched: Accelerate "pick_next_entity" under special condition Michael Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120129163328.GC23408@elte.hu \
--to=mingo@elte.hu \
--cc=a.p.zijlstra@chello.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=wangyun@linux.vnet.ibm.com \
--cc=xiyou.wangcong@gmail.com \
--cc=xtfeng@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.