From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH-RFC 06/10] mips: switch to GENERIC_PCI_IOMAP Date: Mon, 30 Jan 2012 00:45:07 +0200 Message-ID: <20120129223339.GA22666@redhat.com> References: <66457f7750d7d14229fcf8d0b011aba63185a75d.1322163031.git.mst@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Content-Disposition: inline In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-bounces@lists.openrisc.net Errors-To: linux-bounces@lists.openrisc.net To: Kevin Cernekee Cc: Nicolas Pitre , linux-mips@linux-mips.org, linux-m68k@vger.kernel.org, linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, Benjamin Herrenschmidt , linux@openrisc.net, linux-pci@vger.kernel.org, Jesse Barnes , Kumar Gala , Chen Liqin , Paul Mackerras , "H. Peter Anvin" , sparclinux@vger.kernel.org, Guan Xuetao , Lennox Wu , Jesper Nilsson , Russell King , linux-hexagon@vger.kernel.org, Helge Deller , x86@kernel.org, "James E.J. Bottomley" , Ingo Molnar , Geert Uytterhoeven , linux-arch@vger.kernel.org, Arend van Spriel On Sat, Jan 28, 2012 at 02:38:10PM -0800, Kevin Cernekee wrote: > On Thu, Nov 24, 2011 at 12:18 PM, Michael S. Tsirkin wro= te: > > mips copied pci_iomap from generic code, probably to avoid > > pulling the rest of iomap.c in. =A0Since that's in > > a separate file now, we can reuse the common implementation. > = > [snip] > = > > - =A0 =A0 =A0 if (flags & IORESOURCE_IO) > > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 return ioport_map_pci(dev, start, len); > = > While investigating a new warning on the 3.3-rc1 MIPS build (unused > static function ioport_map_pci()), I noticed that this patch has shown > up in Linus' tree as commit eab90291d35438bcebf7c3dc85be66d0f24e3002. > = > I am not completely clear on the implications it has on mapping PCI I/O r= egions: Yes, my bad, I missed the difference between ioport_map_pci and ioport_map for both MIPS and SH. I'll post a patch to fix this, which is probably preferable to reintroducing the code duplication where it might trip us up again. -- = MST From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Sun, 29 Jan 2012 23:44:01 +0100 (CET) Received: from mx1.redhat.com ([209.132.183.28]:12558 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S1903686Ab2A2Wnw (ORCPT ); Sun, 29 Jan 2012 23:43:52 +0100 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q0TMh6QU030435 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 29 Jan 2012 17:43:07 -0500 Received: from redhat.com (vpn-203-124.tlv.redhat.com [10.35.203.124]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q0TMgcAV018377; Sun, 29 Jan 2012 17:42:39 -0500 Date: Mon, 30 Jan 2012 00:45:07 +0200 From: "Michael S. Tsirkin" To: Kevin Cernekee Cc: Ralf Baechle , Richard Henderson , Ivan Kokshaysky , Matt Turner , Russell King , Mikael Starvik , Jesper Nilsson , Richard Kuo , Tony Luck , Fenghua Yu , Geert Uytterhoeven , Michal Simek , Jonas Bonn , Kyle McMartin , Helge Deller , "James E.J. Bottomley" , Benjamin Herrenschmidt , Paul Mackerras , Chen Liqin , Lennox Wu , Paul Mundt , "David S. Miller" , Guan Xuetao , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, Arnd Bergmann , Andrew Morton , Nicolas Pitre , Paul Bolle , Olof Johansson , Rob Herring , Paul Gortmaker , Kumar Gala , Michael Ellerman , Fabio Baltieri , Lucas De Marchi , "John W. Linville" , Lasse Collin , Arend van Spriel , Franky Lin , linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-cris-kernel@axis.com, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k@vger.kernel.org, microblaze-uclinux@itee.uq.edu.au, linux-mips@linux-mips.org, linux@openrisc.net, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-arch@vger.kernel.org, Jesse Barnes , linux-pci@vger.kernel.org Subject: Re: [PATCH-RFC 06/10] mips: switch to GENERIC_PCI_IOMAP Message-ID: <20120129223339.GA22666@redhat.com> References: <66457f7750d7d14229fcf8d0b011aba63185a75d.1322163031.git.mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Scanned-By: MIMEDefang 2.67 on 10.5.11.11 X-archive-position: 32321 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: mst@redhat.com Precedence: bulk X-list: linux-mips Return-Path: On Sat, Jan 28, 2012 at 02:38:10PM -0800, Kevin Cernekee wrote: > On Thu, Nov 24, 2011 at 12:18 PM, Michael S. Tsirkin wrote: > > mips copied pci_iomap from generic code, probably to avoid > > pulling the rest of iomap.c in.  Since that's in > > a separate file now, we can reuse the common implementation. > > [snip] > > > -       if (flags & IORESOURCE_IO) > > -               return ioport_map_pci(dev, start, len); > > While investigating a new warning on the 3.3-rc1 MIPS build (unused > static function ioport_map_pci()), I noticed that this patch has shown > up in Linus' tree as commit eab90291d35438bcebf7c3dc85be66d0f24e3002. > > I am not completely clear on the implications it has on mapping PCI I/O regions: Yes, my bad, I missed the difference between ioport_map_pci and ioport_map for both MIPS and SH. I'll post a patch to fix this, which is probably preferable to reintroducing the code duplication where it might trip us up again. -- MST From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH-RFC 06/10] mips: switch to GENERIC_PCI_IOMAP Date: Mon, 30 Jan 2012 00:45:07 +0200 Message-ID: <20120129223339.GA22666@redhat.com> References: <66457f7750d7d14229fcf8d0b011aba63185a75d.1322163031.git.mst@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Cc: Nicolas Pitre , linux-mips@linux-mips.org, linux-m68k@vger.kernel.org, linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, Benjamin Herrenschmidt , linux@openrisc.net, linux-pci@vger.kernel.org, Jesse Barnes , Kumar Gala , Chen Liqin , Paul Mackerras , "H. Peter Anvin" , sparclinux@vger.kernel.org, Guan Xuetao , Lennox Wu , Jesper Nilsson , Russell King , linux-hexagon@vger.kernel.org, Helge Deller , x86@kernel.org, "James E.J. Bottomley" , Ingo Molnar , Geert Uytterhoeven , linux-arch@vger.kernel.org, Arend van Spriel , To: Kevin Cernekee Return-path: In-Reply-To: List-Id: OpenRISC Linux List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-bounces@lists.openrisc.net On Sat, Jan 28, 2012 at 02:38:10PM -0800, Kevin Cernekee wrote: > On Thu, Nov 24, 2011 at 12:18 PM, Michael S. Tsirkin wro= te: > > mips copied pci_iomap from generic code, probably to avoid > > pulling the rest of iomap.c in. =A0Since that's in > > a separate file now, we can reuse the common implementation. > = > [snip] > = > > - =A0 =A0 =A0 if (flags & IORESOURCE_IO) > > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 return ioport_map_pci(dev, start, len); > = > While investigating a new warning on the 3.3-rc1 MIPS build (unused > static function ioport_map_pci()), I noticed that this patch has shown > up in Linus' tree as commit eab90291d35438bcebf7c3dc85be66d0f24e3002. > = > I am not completely clear on the implications it has on mapping PCI I/O r= egions: Yes, my bad, I missed the difference between ioport_map_pci and ioport_map for both MIPS and SH. I'll post a patch to fix this, which is probably preferable to reintroducing the code duplication where it might trip us up again. -- = MST From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by ozlabs.org (Postfix) with ESMTP id 5D301B6F6F for ; Mon, 30 Jan 2012 09:44:04 +1100 (EST) Date: Mon, 30 Jan 2012 00:45:07 +0200 From: "Michael S. Tsirkin" To: Kevin Cernekee Subject: Re: [PATCH-RFC 06/10] mips: switch to GENERIC_PCI_IOMAP Message-ID: <20120129223339.GA22666@redhat.com> References: <66457f7750d7d14229fcf8d0b011aba63185a75d.1322163031.git.mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 In-Reply-To: Cc: Nicolas Pitre , linux-mips@linux-mips.org, linux-m68k@vger.kernel.org, linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, linux@openrisc.net, linux-pci@vger.kernel.org, Jesse Barnes , Chen Liqin , Paul Mackerras , "H. Peter Anvin" , sparclinux@vger.kernel.org, Guan Xuetao , Lennox Wu , Jonas Bonn , Jesper Nilsson , Russell King , linux-hexagon@vger.kernel.org, Helge Deller , x86@kernel.org, "James E.J. Bottomley" , Ingo Molnar , Geert Uytterhoeven , linux-arch@vger.kernel.org, Arend van Spriel , Matt Turner , Fenghua Yu , Lasse Collin , Arnd Bergmann , Lucas De Marchi , microblaze-uclinux@itee.uq.edu.au, Paul Bolle , Rob Herring , Mikael Starvik , Ivan Kokshaysky , Franky Lin , Thomas Gleixner , Fabio Baltieri , linux-arm-kernel@lists.infradead.org, Richard Henderson , Michael Ellerman , Michal Simek , Tony Luck , linux-parisc@vger.kernel.org, linux-cris-kernel@axis.com, Paul Gortmaker , linux-kernel@vger.kernel.org, Ralf Baechle , Richard Kuo , Kyle McMartin , Paul Mundt , linux-alpha@vger.kernel.org, Olof Johansson , Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S. Miller" List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Sat, Jan 28, 2012 at 02:38:10PM -0800, Kevin Cernekee wrote: > On Thu, Nov 24, 2011 at 12:18 PM, Michael S. Tsirkin wrote: > > mips copied pci_iomap from generic code, probably to avoid > > pulling the rest of iomap.c in.  Since that's in > > a separate file now, we can reuse the common implementation. > > [snip] > > > -       if (flags & IORESOURCE_IO) > > -               return ioport_map_pci(dev, start, len); > > While investigating a new warning on the 3.3-rc1 MIPS build (unused > static function ioport_map_pci()), I noticed that this patch has shown > up in Linus' tree as commit eab90291d35438bcebf7c3dc85be66d0f24e3002. > > I am not completely clear on the implications it has on mapping PCI I/O regions: Yes, my bad, I missed the difference between ioport_map_pci and ioport_map for both MIPS and SH. I'll post a patch to fix this, which is probably preferable to reintroducing the code duplication where it might trip us up again. -- MST