From: Ingo Molnar <mingo@elte.hu>
To: Michael D Labriola <mlabriol@gdeb.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
"H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org,
Michael D Labriola <michael.d.labriola@gmail.com>
Subject: Re: [PATCH] x86, reboot: reduce to a single DMI table for reboot quirks
Date: Mon, 30 Jan 2012 14:42:05 +0100 [thread overview]
Message-ID: <20120130134205.GA3351@elte.hu> (raw)
In-Reply-To: <OFE2532E18.A9BD6FEB-ON85257995.004A4456-85257995.004ABE7E@gdeb.com>
* Michael D Labriola <mlabriol@gdeb.com> wrote:
> > I realize that you only move code here - but it's worth
> > cleaning it up a bit when touching it.
>
> You are requesting that I clean up only the comments that
> appear in the diff, correct? I'll do that as well.
Yeah, and whatever other cleanliness detail you notice: when we
touch some code it is the best opportunity to improve it.
I'd also suggest for ou to do it as two patches: first keep your
existing patch then do a second one on top of it cleaning up any
details, and send me both.
Thanks,
Ingo
prev parent reply other threads:[~2012-01-30 13:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87ty3eb9c9.fsf@gmail.com>
2012-01-30 9:55 ` [PATCH] x86, reboot: reduce to a single DMI table for reboot quirks Ingo Molnar
2012-01-30 13:36 ` Michael D Labriola
2012-01-30 13:42 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120130134205.GA3351@elte.hu \
--to=mingo@elte.hu \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.d.labriola@gmail.com \
--cc=mlabriol@gdeb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.