From: Oleg Nesterov <oleg@redhat.com>
To: Anton Vorontsov <anton.vorontsov@linaro.org>
Cc: "Arve Hjønnevåg" <arve@android.com>,
"KOSAKI Motohiro" <kosaki.motohiro@gmail.com>,
"Greg Kroah-Hartman" <gregkh@suse.de>,
"San Mehat" <san@google.com>, "Colin Cross" <ccross@android.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
linux-kernel@vger.kernel.org, kernel-team@android.com,
linaro-kernel@lists.linaro.org
Subject: Re: [PATCH 3/3] staging: android: lowmemorykiller: Drop tasklist_lock usage
Date: Mon, 30 Jan 2012 14:46:01 +0100 [thread overview]
Message-ID: <20120130134601.GB14110@redhat.com> (raw)
In-Reply-To: <20120130011348.GC30274@oksana.dev.rtsoft.ru>
On 01/30, Anton Vorontsov wrote:
>
> @@ -132,8 +134,8 @@ static int lowmem_shrink(struct shrinker *s, struct shrink_control *sc)
> }
> selected_oom_adj = min_adj;
>
> - read_lock(&tasklist_lock);
> - for_each_process(p) {
> + for_each_tgid(ns, iter) {
This makes force_sig() below unsafe, it can race with the exiting task.
Oleg.
prev parent reply other threads:[~2012-01-30 13:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-30 1:13 [PATCH 3/3] staging: android: lowmemorykiller: Drop tasklist_lock usage Anton Vorontsov
2012-01-30 13:46 ` Oleg Nesterov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120130134601.GB14110@redhat.com \
--to=oleg@redhat.com \
--cc=anton.vorontsov@linaro.org \
--cc=arve@android.com \
--cc=ccross@android.com \
--cc=ebiederm@xmission.com \
--cc=gregkh@suse.de \
--cc=kernel-team@android.com \
--cc=kosaki.motohiro@gmail.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=san@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.