From: Andrew Morton <akpm@linux-foundation.org>
To: Peter Meerwald <pmeerw@pmeerw.net>,
linux-kernel@vger.kernel.org, lars@metafoo.de, rpurdie@rpsys.net
Subject: Re: [PATCH v2] add LED driver for PCA9663 I2C chip
Date: Mon, 30 Jan 2012 16:34:24 -0800 [thread overview]
Message-ID: <20120130163424.ef8eb9af.akpm@linux-foundation.org> (raw)
In-Reply-To: <20120130162849.635c83a9.akpm@linux-foundation.org>
On Mon, 30 Jan 2012 16:28:49 -0800
Andrew Morton <akpm@linux-foundation.org> wrote:
> > +exit:
> > + while (i--) {
> > + led_classdev_unregister(&pca9633[i].led_cdev);
> > + cancel_work_sync(&pca9633[i].work);
> > + }
>
> This (untested!) loop has an off-by-one error.
Well, it's partly wrong. It's wrong for the cancel_work_sync() but not
for the led_classdev_unregister(). The cancel_work_sync() can just be
removed: we haven't scheduled any works yet.
next prev parent reply other threads:[~2012-01-31 0:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-18 19:51 [PATCH v2] add LED driver for PCA9663 I2C chip Peter Meerwald
2012-01-31 0:28 ` Andrew Morton
2012-01-31 0:34 ` Andrew Morton [this message]
2012-02-02 10:42 ` Peter Meerwald
2012-02-02 19:54 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120130163424.ef8eb9af.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.