Re: [PATCH 3/5] staging: tidspbridge: Lindent to drv_interface.c

["Víctor M. Jáquez L." <vjaquez@igalia.com>]

On Mon, Jan 30, 2012 at 11:25:34AM -0600, Ramirez Luna, Omar wrote:
> 2012/1/23 Víctor Manuel Jáquez Leal <vjaquez@igalia.com>:
> > No functional changes.
> >
> > According to Lindent, the file drv_internface.c had some lines with bad
> > indentation.
> >
> > This commit is the output of Lindent.
> 
> Usually lindent tends to do whatever it wants, unless carefully
> configured...

Thanks Omar!

I'll post a v2 of this patch set, with a couple things more and with more
attention on what lindent does in this one, if that's ok.

vmjl

> 
> ...
> > @@ -342,9 +342,10 @@ static void bridge_recover(struct work_struct *work)
> >        if (atomic_read(&bridge_cref)) {
> >                INIT_COMPLETION(bridge_comp);
> >                while (!wait_for_completion_timeout(&bridge_comp,
> > -                                               msecs_to_jiffies(REC_TIMEOUT)))
> > -                       pr_info("%s:%d handle(s) still opened\n",
> > -                                       __func__, atomic_read(&bridge_cref));
> > +                                                   msecs_to_jiffies
> > +                                                   (REC_TIMEOUT)))
> 
> Like here, it just split msecs_to_jiffies(REC_TIMEOUT) into 2 lines
> making it a little harder to read.
> 
> > +                       pr_info("%s:%d handle(s) still opened\n", __func__,
> > +                               atomic_read(&bridge_cref));
> 
> I remember the rule was to break lines as far to the right as
> possible, no? Chapter 2 CodingStyle, same for the other similar
> changes.
> 
> ...
> > @@ -547,10 +548,9 @@ static int __devexit omap34_xx_bridge_remove(struct platform_device *pdev)
> >                pr_err("%s: Failed to retrieve the object handle\n", __func__);
> >                goto func_cont;
> >        }
> > -
> 
> Blank line removed?
> 
> >  #ifdef CONFIG_TIDSPBRIDGE_DVFS
> >        if (cpufreq_unregister_notifier(&iva_clk_notifier,
> > -                                               CPUFREQ_TRANSITION_NOTIFIER))
> > +                                       CPUFREQ_TRANSITION_NOTIFIER))
> >                pr_err("%s: cpufreq_unregister_notifier failed for iva2_ck\n",
> >                       __func__);
> >  #endif /* #ifdef CONFIG_TIDSPBRIDGE_DVFS */
> > --
> > 1.7.8.3
> >
> 
> Regards,
> 
> Omar
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>