Re: [PATCH 2/2] nfsd: fix default iosize calculation on 32bit

["J. Bruce Fields" <bfields@fieldses.org>]

On Mon, Jan 30, 2012 at 05:42:45PM -0500, J. Bruce Fields wrote:
> From: "J. Bruce Fields" <bfields@redhat.com>
> 
> The rpc buffers will be allocated out of low memory, so we should really
> only be taking that into account.

I could have sworm this problem had already been fixed, or at least
discussed, but can't find any reference now.

--b.

> 
> Signed-off-by: J. Bruce Fields <bfields@redhat.com>
> ---
>  fs/nfsd/nfssvc.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/nfsd/nfssvc.c b/fs/nfsd/nfssvc.c
> index 2ad5ffe..53c89f7 100644
> --- a/fs/nfsd/nfssvc.c
> +++ b/fs/nfsd/nfssvc.c
> @@ -314,7 +314,7 @@ static int nfsd_get_default_max_blksize(void)
>  	unsigned long bytes;
>  
>  	si_meminfo(&i);
> -	target = i.totalram << PAGE_SHIFT;
> +	target = (i.totalram - i.totalhigh) << PAGE_SHIFT;
>  	/*
>  	 * Aim for 1/4096 of memory per thread This gives 1MB on 4Gig
>  	 * machines, but only uses 32K on 128M machines.  Bottom out at
> -- 
> 1.7.5.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html