From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Víctor Manuel Jáquez Leal" <vjaquez@igalia.com>
Cc: Omar Ramirez Luna <omar.ramirez@ti.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
Armando Uribe <x0095078@ti.com>,
devel@driverdev.osuosl.org, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/8] staging: tidspbridge: silence the compiler
Date: Tue, 31 Jan 2012 11:05:43 +0300 [thread overview]
Message-ID: <20120131080543.GA3294@mwanda> (raw)
In-Reply-To: <d25cfe1b88f2b749cb31887d551a1c9b0fcde42e.1327964066.git.vjaquez@igalia.com>
[-- Attachment #1: Type: text/plain, Size: 642 bytes --]
On Tue, Jan 31, 2012 at 12:12:20AM +0100, Víctor Manuel Jáquez Leal wrote:
> Silence the warning when compiling drv_interface.c
>
> Signed-off-by: Víctor Manuel Jáquez Leal <vjaquez@igalia.com>
What does the compiler warn about here? Normally you would cut and
paste the warning into the commit message. But at least give us a
hint.
You could also reformat that printk so the message is on one line.
dev_dbg(bridge,
"%s: vm filp %p offset %x start %lx end %lx page_prot %ulx flags %lx\n",
__func__, filp, offset, vma->vm_start, vma->vm_end,
vma->vm_page_prot, vma->vm_flags);
regards,
dan carpenter
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-01-31 8:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-30 23:12 [PATCH v2 0/8] staging: tidspbridge: clean up drv_interface.c Víctor Manuel Jáquez Leal
2012-01-30 23:12 ` [PATCH v2 1/8] staging: tidspbridge: more readable code Víctor Manuel Jáquez Leal
2012-01-30 23:12 ` [PATCH v2 2/8] staging: tidspbridge: remove unused header Víctor Manuel Jáquez Leal
2012-01-30 23:12 ` [PATCH v2 3/8] staging: tidspbridge: Lindent to drv_interface.c Víctor Manuel Jáquez Leal
2012-01-30 23:12 ` [PATCH v2 4/8] staging: tidspbridge: silence the compiler Víctor Manuel Jáquez Leal
2012-01-31 8:05 ` Dan Carpenter [this message]
2012-01-31 11:19 ` Víctor M. Jáquez L.
2012-01-31 11:29 ` Dan Carpenter
2012-02-02 22:51 ` Víctor Manuel Jáquez Leal
2012-01-30 23:12 ` [PATCH v2 5/8] staging: tidspbridge: remove header inclusions Víctor Manuel Jáquez Leal
2012-01-30 23:12 ` [PATCH v2 6/8] staging: tidspbridge: remove trivial assert Víctor Manuel Jáquez Leal
2012-01-30 23:12 ` [PATCH v2 7/8] staging: tidspbridge: clean up bridge_mmap() Víctor Manuel Jáquez Leal
2012-01-30 23:12 ` [PATCH v2 8/8] staging: tidspbridge: use the driver name string Víctor Manuel Jáquez Leal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120131080543.GA3294@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=omar.ramirez@ti.com \
--cc=vjaquez@igalia.com \
--cc=x0095078@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.