From: Sascha Hauer <s.hauer@pengutronix.de>
To: Robert Jarzmik <robert.jarzmik@free.fr>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] arm/mach-pxa: add pulse width modulator controller
Date: Tue, 31 Jan 2012 10:37:06 +0100 [thread overview]
Message-ID: <20120131093706.GN1990@pengutronix.de> (raw)
In-Reply-To: <87zkd9gmdz.fsf@free.fr>
On Fri, Jan 27, 2012 at 05:07:04PM +0100, Robert Jarzmik wrote:
> Sascha Hauer <s.hauer@pengutronix.de> writes:
>
> > On Thu, Jan 26, 2012 at 08:55:28PM +0100, Robert Jarzmik wrote:
> >> Add PXA embedded pulse width modulator support. The PWM can
> >> generate signals from 49.6kHz to 1.625MHz.
> >>
> >> Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
> >> ---
> >
> > [...]
> >
> >> +
> >> + /* NOTE: the clock to PWM has to be enabled first
> >> + * before writing to the registers
> >> + */
> >
> > Does this mean that pwm_enable() has to be called prior to pxm_config()?
> Yes.
>
> > I think we should rather have a real pwm API.
> So do I.
>
> > The following Kernel patch could be easily adopted and the overhead is
> > acceptable I think.
> Would you adapt it or do you want me to do it ?
I just sent a patch, compile tested only.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2012-01-31 9:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-26 19:55 [PATCH] drivers/mtd: fix mtdraw write support Robert Jarzmik
2012-01-26 19:55 ` [PATCH] drivers/mtd: fix docg3 " Robert Jarzmik
2012-01-26 19:55 ` [PATCH] arm/mach-pxa: add standard LCD panel GPIO settings Robert Jarzmik
2012-01-26 19:55 ` [PATCH] arm/mach-pxa: add CCCR bits definitions Robert Jarzmik
2012-01-26 19:55 ` [PATCH] arm/mach-pxa: add pulse width modulator controller Robert Jarzmik
2012-01-27 11:42 ` Sascha Hauer
2012-01-27 16:07 ` Robert Jarzmik
2012-01-31 9:37 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120131093706.GN1990@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=robert.jarzmik@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.