From: "Ted Ts'o" <tytso@mit.edu>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Matt Mackall <mpm@selenic.com>,
Greg Kroah-Hartman <greg@kroah.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] char random: fix boot id uniqueness race
Date: Tue, 31 Jan 2012 10:59:55 -0500 [thread overview]
Message-ID: <20120131155955.GA24356@thunk.org> (raw)
In-Reply-To: <20120130044012.GA31966@Krystal>
On Sun, Jan 29, 2012 at 11:40:12PM -0500, Mathieu Desnoyers wrote:
> Index: linux-2.6-lttng/drivers/char/random.c
> ===================================================================
> --- linux-2.6-lttng.orig/drivers/char/random.c
> +++ linux-2.6-lttng/drivers/char/random.c
> @@ -1231,6 +1231,8 @@ static int min_read_thresh = 8, min_writ
> static int max_read_thresh = INPUT_POOL_WORDS * 32;
> static int max_write_thresh = INPUT_POOL_WORDS * 32;
> static char sysctl_bootid[16];
> +static int boot_id_generated;
> +static DEFINE_MUTEX(boot_id_mutex);
My preference would be to put these statics in proc_do_uuid(), but
that's arguably a nit.
> + } else {
> + if (unlikely(!ACCESS_ONCE(boot_id_generated))) {
> + mutex_lock(&boot_id_mutex);
> + if (!boot_id_generated) {
> + generate_random_uuid(uuid);
> + /* Store uuid before boot_id_generated. */
> + smp_wmb();
> + boot_id_generated = 1;
> + }
> + mutex_unlock(&boot_id_mutex);
> + } else {
> + /* Load boot_id_generated before uuid */
> + smp_rmb();
> + }
> + }
I don't believe the smp_wmb() and smp_rmb() are necessary here; the
mutex_lock() and mutex_unlock() should put the necessary memory
barriers in place.
Regards,
- Ted
next prev parent reply other threads:[~2012-01-31 16:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-30 4:40 [PATCH] char random: fix boot id uniqueness race Mathieu Desnoyers
2012-01-31 15:59 ` Ted Ts'o [this message]
2012-01-31 16:25 ` Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120131155955.GA24356@thunk.org \
--to=tytso@mit.edu \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mpm@selenic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.