All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: "Dan Carpenter" <dan.carpenter@oracle.com>,
	"Arve Hjønnevåg" <arve@android.com>
Cc: devel@driverdev.osuosl.org,
	Christopher Lais <chris+android@zenthought.org>,
	Greg Kroah-Hartman <gregkh@suse.de>,
	linux-kernel@vger.kernel.org, Al Viro <viro@ZenIV.linux.org.uk>
Subject: Re: [PATCH 1/2] Staging: android: binder: Add some error checks
Date: Tue, 31 Jan 2012 10:52:28 -0800	[thread overview]
Message-ID: <20120131185228.GA21481@kroah.com> (raw)
In-Reply-To: <20120121082208.GL3294@mwanda>

On Sat, Jan 21, 2012 at 11:22:08AM +0300, Dan Carpenter wrote:
> On Fri, Jan 20, 2012 at 07:56:20PM -0800, Arve Hjønnevåg wrote:
> > - Add a mutex to protect against two processes mmapping the
> >   same binder_proc.
> > - After locking mmap_sem, check that the vma we want to access
> >   (still) points to the same mm_struct.
> > - Use proc->tsk instead of current to get the files struct since
> >   this is where we get the rlimit from.
> 
> This doesn't seem related to the locking change at all.  Probably
> this patch should be split into three patches, one bugfix per
> patch, unless they are very closely related.

I agree.  Arve, is this all fixing one problem, or multiple ones?  If
multiple ones, we need this split up into multiple patches.

thanks,

greg k-h

  reply	other threads:[~2012-01-31 18:58 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-21  3:56 [PATCH 0/2] Binder bug fixes Arve Hjønnevåg
2012-01-21  3:56 ` [PATCH 1/2] Staging: android: binder: Add some error checks Arve Hjønnevåg
2012-01-21  8:22   ` Dan Carpenter
2012-01-31 18:52     ` Greg KH [this message]
2012-01-31 23:20       ` Arve Hjønnevåg
2012-02-01  6:53         ` Dan Carpenter
2012-02-01 22:29           ` Arve Hjønnevåg
2012-02-01 22:47             ` Greg KH
2012-02-01 23:29               ` [PATCH] Staging: android: binder: Fix crashes when sharing a binder file between processes Arve Hjønnevåg
2012-02-02  6:27               ` [PATCH 1/2] Staging: android: binder: Add some error checks Dan Carpenter
2012-01-21  3:56 ` [PATCH 2/2] Staging: android: binder: Don't call dump_stack in binder_vma_open Arve Hjønnevåg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120131185228.GA21481@kroah.com \
    --to=greg@kroah.com \
    --cc=arve@android.com \
    --cc=chris+android@zenthought.org \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.