From: Ingo Molnar <mingo@elte.hu>
To: Arun Sharma <asharma@fb.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
David Miller <davem@davemloft.net>,
Glauber Costa <glommer@parallels.com>,
christoph.paasch@uclouvain.be
Subject: Re: [PATCH] net: Disambiguate kernel message
Date: Tue, 31 Jan 2012 20:44:50 +0100 [thread overview]
Message-ID: <20120131194450.GA8020@elte.hu> (raw)
In-Reply-To: <20120131181554.GA24397@dev3310.snc6.facebook.com>
* Arun Sharma <asharma@fb.com> wrote:
> + printk(KERN_INFO "TCP: too many orphaned "
> "sockets\n");
> + printk(KERN_INFO "TCP: out of memory. "
> + "Consider tuning tcp_mem\n");
> + printk(KERN_INFO "TCP: out of memory. "
> + "Consider tuning tcp_mem\n");
> + if (too_many_orphans && net_ratelimit())
> + printk(KERN_INFO "TCP: too many orphaned sockets\n");
A small detail: please don't line break user-visible strings in
mid sentence. Just keep the line long. Makes it much easier to
search for the source of a kernel message:
git grep "TCP: too many orphaned sockets"
Thanks,
Ingo
next prev parent reply other threads:[~2012-01-31 19:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-30 22:41 [PATCH] net: Disambiguate kernel message Arun Sharma
2012-01-31 4:22 ` Bjorn Helgaas
2012-01-31 18:15 ` Arun Sharma
2012-01-31 18:50 ` Joe Perches
2012-01-31 19:47 ` Arun Sharma
2012-01-31 20:09 ` Joe Perches
2012-01-31 20:46 ` Arun Sharma
2012-01-31 20:55 ` Joe Perches
2012-01-31 21:15 ` David Miller
2012-01-31 22:05 ` Arun Sharma
2012-01-31 22:12 ` Joe Perches
2012-02-01 19:42 ` David Miller
2012-01-31 19:44 ` Ingo Molnar [this message]
2012-01-31 8:51 ` Christoph Paasch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120131194450.GA8020@elte.hu \
--to=mingo@elte.hu \
--cc=asharma@fb.com \
--cc=bhelgaas@google.com \
--cc=christoph.paasch@uclouvain.be \
--cc=davem@davemloft.net \
--cc=glommer@parallels.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.