From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH] staging: tidspbridge: enable watchdog by default Date: Tue, 31 Jan 2012 19:44:45 -0800 Message-ID: <20120201034445.GA2979@kroah.com> References: <1328058094-28483-1-git-send-email-felipe.contreras@gmail.com> <20120201011239.GA797@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from out1-smtp.messagingengine.com ([66.111.4.25]:36354 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752531Ab2BAD4V (ORCPT ); Tue, 31 Jan 2012 22:56:21 -0500 Received: from compute4.internal (compute4.nyi.mail.srv.osa [10.202.2.44]) by gateway1.nyi.mail.srv.osa (Postfix) with ESMTP id E48F2206B5 for ; Tue, 31 Jan 2012 22:45:40 -0500 (EST) Content-Disposition: inline In-Reply-To: Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Felipe Contreras Cc: "open list:STAGING SUBSYSTEM" , Jiri Kosina , Felipe Contreras , "Justin P. Mattock" , linux-omap@vger.kernel.org On Wed, Feb 01, 2012 at 03:37:55AM +0200, Felipe Contreras wrote: > On Wed, Feb 1, 2012 at 3:12 AM, Greg KH wrote: > > On Wed, Feb 01, 2012 at 03:01:32AM +0200, Felipe Contreras wrote: > >> From: Felipe Contreras > >> > >> The public images have it enabled, it's safer, and we get rid of t= his > >> warning: > >> > >> WARNING: at arch/arm/mach-omap2/omap_l3_smx.c:162 omap3_l3_app_irq= +0x114/0x15c() > >> In-band Error seen by IVA_SS =A0at address 0 > >> Modules linked in: bridgedriver(C+) mailbox_mach mailbox ipv6 g_et= her > >> [] (unwind_backtrace+0x0/0xec) from [] (warn_s= lowpath_common+0x4c/0x64) > >> [] (warn_slowpath_common+0x4c/0x64) from [] (w= arn_slowpath_fmt+0x2c/0x3c) > >> [] (warn_slowpath_fmt+0x2c/0x3c) from [] (omap= 3_l3_app_irq+0x114/0x15c) > >> [] (omap3_l3_app_irq+0x114/0x15c) from [] (han= dle_irq_event_percpu+0x28/0x174) > >> [] (handle_irq_event_percpu+0x28/0x174) from [= ] (handle_irq_event+0x28/0x38) > >> [] (handle_irq_event+0x28/0x38) from [] (handl= e_level_irq+0xb8/0xe0) > >> [] (handle_level_irq+0xb8/0xe0) from [] (gener= ic_handle_irq+0x28/0x30) > >> [] (generic_handle_irq+0x28/0x30) from [] (han= dle_IRQ+0x60/0x84) > >> [] (handle_IRQ+0x60/0x84) from [] (__irq_svc+0= x34/0x80) > >> [] (__irq_svc+0x34/0x80) from [] (v7_dma_inv_r= ange+0x34/0x48) > >> [] (v7_dma_inv_range+0x34/0x48) from [] (dma_c= ache_maint_page+0x2c/0x34) > >> [] (dma_cache_maint_page+0x2c/0x34) from [] (_= __dma_page_dev_to_cpu+0x24/0x68) > >> [] (___dma_page_dev_to_cpu+0x24/0x68) from [] = (dma_unmap_sg+0x40/0x64) > >> [] (dma_unmap_sg+0x40/0x64) from [] (omap_hsmm= c_post_req+0x3c/0x48) > >> [] (omap_hsmmc_post_req+0x3c/0x48) from [] (mm= c_post_req+0x18/0x1c) > >> [] (mmc_post_req+0x18/0x1c) from [] (mmc_start= _req+0xd4/0xec) > >> [] (mmc_start_req+0xd4/0xec) from [] (mmc_blk_= issue_rw_rq+0x64/0x244) > >> [] (mmc_blk_issue_rw_rq+0x64/0x244) from [] (m= mc_blk_issue_rq+0x2ac/0x2cc) > >> [] (mmc_blk_issue_rq+0x2ac/0x2cc) from [] (mmc= _queue_thread+0x8c/0xf8) > >> [] (mmc_queue_thread+0x8c/0xf8) from [] (kthre= ad+0x84/0x8c) > >> [] (kthread+0x84/0x8c) from [] (kernel_thread_= exit+0x0/0x8) > >> ---[ end trace 5dec1c8d7857375d ]--- > >> > >> Signed-off-by: Felipe Contreras > >> --- > >> =A0drivers/staging/tidspbridge/Kconfig | =A0 =A01 + > >> =A01 files changed, 1 insertions(+), 0 deletions(-) > >> > >> diff --git a/drivers/staging/tidspbridge/Kconfig b/drivers/staging= /tidspbridge/Kconfig > >> index 21a559e..614e974 100644 > >> --- a/drivers/staging/tidspbridge/Kconfig > >> +++ b/drivers/staging/tidspbridge/Kconfig > >> @@ -61,6 +61,7 @@ config TIDSPBRIDGE_CACHE_LINE_CHECK > >> =A0config TIDSPBRIDGE_WDT3 > >> =A0 =A0 =A0 bool "Enable watchdog timer" > >> =A0 =A0 =A0 depends on TIDSPBRIDGE > >> + =A0 =A0 default y > > > > Nothing is ever default y, sorry, I can't accept this. >=20 > % git grep 'default y' -- 'drivers/*/Kconfig' | wc -l > 493 That's nice, but proves nothing, no new entries should be y. If it should be y, then it should just not be an option and always enabled, right? Why not do that? greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-omap" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html