diff for duplicates of <20120201132415.b09d8710.akpm@linux-foundation.org> diff --git a/a/1.txt b/N1/1.txt index 02b6f7e..09935e4 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -19,7 +19,7 @@ Rik van Riel <riel@redhat.com> wrote: > same. > > My patch temporarily broke things, by testing for order < 0, -> instead of the explicit cc->order = -1 used elsewhere in +> instead of the explicit cc->order == -1 used elsewhere in > the code. > > I did not notice it in my own testing because I tested on @@ -29,7 +29,7 @@ Rik van Riel <riel@redhat.com> wrote: > > In my test tree, I had (cc->sync || !compaction_deferred(zone, cc->order)). > -> Arguably, testing for cc->order = -1 (or cc->order < 0) is +> Arguably, testing for cc->order == -1 (or cc->order < 0) is > better anyway. I suppose it would be nicer to make the code in __compact_pgdat() match @@ -42,8 +42,15 @@ all the other places whcih do this: INIT_LIST_HEAD(&cc->migratepages); - if (cc->order < 0 || !compaction_deferred(zone, cc->order)) -+ if (cc->order = -1 || !compaction_deferred(zone, cc->order)) ++ if (cc->order == -1 || !compaction_deferred(zone, cc->order)) compact_zone(zone, cc); if (cc->order > 0) { _ + +-- +To unsubscribe, send a message with 'unsubscribe linux-mm' in +the body to majordomo@kvack.org. For more info on Linux MM, +see: http://www.linux-mm.org/ . +Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ +Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> diff --git a/a/content_digest b/N1/content_digest index 78851ae..960cbf7 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,7 +3,7 @@ "ref\04F29ABD6.70704@redhat.com\0" "From\0Andrew Morton <akpm@linux-foundation.org>\0" "Subject\0Re: [patch] mm: compaction: make compact_control order signed\0" - "Date\0Wed, 01 Feb 2012 21:24:15 +0000\0" + "Date\0Wed, 1 Feb 2012 13:24:15 -0800\0" "To\0Rik van Riel <riel@redhat.com>\0" "Cc\0Dan Carpenter <dan.carpenter@oracle.com>" Mel Gorman <mel@csn.ul.ie> @@ -34,7 +34,7 @@ "> same.\n" "> \n" "> My patch temporarily broke things, by testing for order < 0,\n" - "> instead of the explicit cc->order = -1 used elsewhere in\n" + "> instead of the explicit cc->order == -1 used elsewhere in\n" "> the code.\n" "> \n" "> I did not notice it in my own testing because I tested on\n" @@ -44,7 +44,7 @@ "> \n" "> In my test tree, I had (cc->sync || !compaction_deferred(zone, cc->order)).\n" "> \n" - "> Arguably, testing for cc->order = -1 (or cc->order < 0) is\n" + "> Arguably, testing for cc->order == -1 (or cc->order < 0) is\n" "> better anyway.\n" "\n" "I suppose it would be nicer to make the code in __compact_pgdat() match\n" @@ -57,10 +57,17 @@ " \t\tINIT_LIST_HEAD(&cc->migratepages);\n" " \n" "-\t\tif (cc->order < 0 || !compaction_deferred(zone, cc->order))\n" - "+\t\tif (cc->order = -1 || !compaction_deferred(zone, cc->order))\n" + "+\t\tif (cc->order == -1 || !compaction_deferred(zone, cc->order))\n" " \t\t\tcompact_zone(zone, cc);\n" " \n" " \t\tif (cc->order > 0) {\n" - _ + "_\n" + "\n" + "--\n" + "To unsubscribe, send a message with 'unsubscribe linux-mm' in\n" + "the body to majordomo@kvack.org. For more info on Linux MM,\n" + "see: http://www.linux-mm.org/ .\n" + "Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/\n" + "Don't email: <a href=mailto:\"dont@kvack.org\"> email@kvack.org </a>" -922c9f1451e8f8fbcaf7b924dc8ba44b56fd4ca1913a5606f58c3b3581f98d71 +3c292c40900c25c477baf3eb24c7d08b80ee6aaa153f39f74f3131dd53981175
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.