From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Linus Walleij <linus.walleij@stericsson.com>,
Samuel Ortiz <sameo@linux.intel.com>,
linux-kernel@vger.kernel.org,
Michel Jaouen <michel.jaouen@stericsson.com>,
Maxime Coquelin <maxime.coquelin@st-ericsson.com>,
Alex Macro <alex.macro@stericsson.com>
Subject: Re: [PATCH] mfd/ab8500: support AB9540 variant
Date: Wed, 1 Feb 2012 14:49:25 +0000 [thread overview]
Message-ID: <20120201144925.GE17170@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <CACRpkdZjh6J_=DG58DkWO0bnj2Np3ujagcdOgNtYq2GfN30uRQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 618 bytes --]
On Wed, Feb 01, 2012 at 03:42:59PM +0100, Linus Walleij wrote:
> For newer ASICs we solve it by not providing platform data
> and instead fall back to reading chip revision.
Given all that it sounds like it'd be more accurate to say that for old
chips we fall back on platform data - fall back sounds like it's a
failure mode but it seems like the opposite is true.
A more idiomatic way of doing this would be to register the device with
the appropriate name and then use driver data in the i2c_device_id to
pick the appropriate variant data up - this has the added bonus of
getting you a free device tree binding.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-02-01 14:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-01 11:02 [PATCH] mfd/ab8500: support AB9540 variant Linus Walleij
2012-02-01 11:31 ` Mark Brown
2012-02-01 14:42 ` Linus Walleij
2012-02-01 14:49 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120201144925.GE17170@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alex.macro@stericsson.com \
--cc=linus.walleij@linaro.org \
--cc=linus.walleij@stericsson.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.coquelin@st-ericsson.com \
--cc=michel.jaouen@stericsson.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.