Re: [PATCH 2/4] qcserial: log when an interface has too many altsettings

[Greg KH <gregkh@linuxfoundation.org>]

On Wed, Feb 01, 2012 at 04:47:22PM -0500, ttuttle wrote:
> On Wed, Feb 1, 2012 at 16:11, Greg KH <gregkh@linuxfoundation.org> wrote:
> >> +             else if (serial->interface->num_altsetting > 2) {
> >> +                     dev_err(&serial->dev->dev,
> >> +                             "too many altsettings: %u",
> >> +                             serial->interface->num_altsetting);
> >
> > Why would this happen?  And what does spitting out an error do about it?
> > What are we supposed to do with this information?
> 
> This would happen if we found a device that was returning an
> unexpected USB configuration.  We've never actually seen this happen
> -- it was just there in case.  I can drop it if you think it's not
> worth the trouble.

As the code properly handles such an error, my point is, if a user sees
this new scary message, what are they supposed to do with it?

So yes, please drop it.

Are you going to resend this series based on the comments so far?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html