From: Daniel Vetter <daniel@ffwll.ch>
To: Daniel Vetter <daniel.vetter@ffwll.ch>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 2/3] drm/i915: consolidate swizzling control bit frobbing
Date: Wed, 1 Feb 2012 23:23:09 +0100 [thread overview]
Message-ID: <20120201222309.GE8395@phenom.ffwll.local> (raw)
In-Reply-To: <20120201213729.GA19242@seagal.amr.corp.intel.com>
On Wed, Feb 01, 2012 at 01:37:29PM -0800, Ben Widawsky wrote:
> On Tue, Jan 31, 2012 at 04:47:55PM +0100, Daniel Vetter wrote:
> > On gen5 we also need to correctly set up swizzling in the display
> > scanout engine, but only there. Consolidate this into the same
> > function.
> >
> > This has a small effect on ums setups - the kernel now also sets this
> > bit in addition to userspace setting it. Given that this code only
> > runs when userspace either can't (resume, gpu reset) or explicitly
> > won't(gem_init) touch the hw this shouldn't have an adverse effect.
> >
> > Signed-Off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> > ---
>
> Have you tested this well?
> From bspec:
> Note: For ILK Display Engine can(?) implement the A[6] swizzling
> structure however it will not be used – corresponding bits will be set
> to “00”
I've simply moved the check around and my and checked whether I haven't
broken things. But resetting that bit seriously creates swizzling havoc on
my screen, so I think it's required ;-)
Cheers, Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2012-02-01 22:23 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-31 15:47 [PATCH 1/3] drm/i915: swizzling support for snb/ivb Daniel Vetter
2012-01-31 15:47 ` [PATCH 2/3] drm/i915: consolidate swizzling control bit frobbing Daniel Vetter
2012-02-01 21:37 ` Ben Widawsky
2012-02-01 22:23 ` Daniel Vetter [this message]
2012-02-08 22:17 ` Ben Widawsky
2012-02-08 22:19 ` Daniel Vetter
2012-01-31 15:47 ` [PATCH 3/3] drm/i915: add gen6+ registers to i915_swizzle_info Daniel Vetter
2012-02-01 21:39 ` Ben Widawsky
2012-02-08 22:20 ` Daniel Vetter
2012-02-01 21:35 ` [PATCH 1/3] drm/i915: swizzling support for snb/ivb Ben Widawsky
2012-02-01 22:16 ` Daniel Vetter
2012-02-01 22:26 ` Chris Wilson
2012-02-01 23:15 ` [PATCH] " Daniel Vetter
2012-02-02 5:30 ` Ben Widawsky
2012-02-02 8:40 ` Daniel Vetter
2012-02-05 3:13 ` Ben Widawsky
2012-02-06 16:06 ` Daniel Vetter
2012-02-02 8:58 ` Daniel Vetter
2012-02-04 20:59 ` Eric Anholt
2012-02-06 15:45 ` Daniel Vetter
2012-02-07 19:56 ` Eric Anholt
2012-02-08 22:17 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120201222309.GE8395@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.