From: Jonathan Nieder <jrnieder@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Ramsay Jones <ramsay@ramsay1.demon.co.uk>,
David Barr <davidbarr@google.com>,
GIT Mailing-list <git@vger.kernel.org>,
Dmitry Ivankov <divanorama@gmail.com>
Subject: [PATCH/RFC 0/3] Re: [PATCH] vcs-svn: Fix some compiler warnings
Date: Thu, 2 Feb 2012 04:41:28 -0600 [thread overview]
Message-ID: <20120202104128.GG3823@burratino> (raw)
In-Reply-To: <7vipjpzxav.fsf@alter.siamese.dyndns.org>
Junio C Hamano wrote:
> I'd hold the branch in 'next' for now, until this gets resolved (one
> possible resolution is to declare Ramsey's patch is good enough for now,
> and do the follow-up later).
Sounds sensible. How about the following? Intended to replace
Ramsay's patch. Not well tested yet.
By the way, wouldn't the (p->field < 0) test in grep.c line 330
trigger the same compiler bug?
Jonathan Nieder (2):
vcs-svn: allow import of > 4GiB files
vcs-svn: suppress a -Wtype-limits warning
Ramsay Allan Jones (1):
vcs-svn: rename check_overflow arguments for clarity
vcs-svn/fast_export.c | 15 +++++++++------
vcs-svn/fast_export.h | 4 ++--
vcs-svn/sliding_window.c | 10 +++++-----
vcs-svn/svndump.c | 21 +++++++++++++++------
4 files changed, 31 insertions(+), 19 deletions(-)
next prev parent reply other threads:[~2012-02-02 10:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-31 18:48 [PATCH] vcs-svn: Fix some compiler warnings Ramsay Jones
2012-01-31 19:20 ` Jonathan Nieder
2012-01-31 20:14 ` Junio C Hamano
2012-02-02 4:14 ` Junio C Hamano
2012-02-02 10:41 ` Jonathan Nieder [this message]
2012-02-02 10:59 ` [PATCH 1/3] vcs-svn: rename check_overflow arguments for clarity Jonathan Nieder
2012-02-02 11:05 ` Dmitry Ivankov
2012-02-02 11:16 ` Jonathan Nieder
2012-02-02 11:25 ` David Barr
2012-02-02 11:27 ` Jonathan Nieder
2012-02-02 18:56 ` Junio C Hamano
2012-02-02 11:03 ` [PATCH 2/3] vcs-svn: allow import of > 4GiB files Jonathan Nieder
2012-02-02 11:06 ` [PATCH 3/3] vcs-svn: suppress a -Wtype-limits warning Jonathan Nieder
2012-02-02 22:18 ` Ramsay Jones
2012-02-02 18:24 ` [PATCH] vcs-svn: Fix some compiler warnings Ramsay Jones
2012-02-02 18:53 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120202104128.GG3823@burratino \
--to=jrnieder@gmail.com \
--cc=davidbarr@google.com \
--cc=divanorama@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ramsay@ramsay1.demon.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.