From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH] cgroup: remove cgroup_subsys argument from callbacks Date: Thu, 2 Feb 2012 09:26:11 -0800 Message-ID: <20120202172611.GF19837@google.com> References: <4F278078.5030703@cn.fujitsu.com> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=h/EYzfFDEnFDl8rsT0oTY/hzguWtB8Of0yiXu/dQtbo=; b=en6h5NHCoXJKEOh6yZyhlSc51VmAXrwU3tsSWd3vhqCTZmOHu7DR+3a7p+G5vi0Fza jnSFktEC1wrPmSAPJtmkY42udedEvNgT4o3CP2bAC/JrMrosBaKpB9R1xzhq6eu9noQw Wl9sduDWEfMhuM5yGVfShGWf9yfA5/sWpCmrw= Content-Disposition: inline In-Reply-To: <4F278078.5030703@cn.fujitsu.com> Sender: owner-linux-mm@kvack.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Li Zefan Cc: LKML , container cgroup , Cgroups , linux-mm@kvack.org, netdev On Tue, Jan 31, 2012 at 01:47:36PM +0800, Li Zefan wrote: > The argument is not used at all, and it's not necessary, because > a specific callback handler of course knows which subsys it > belongs to. > > Now only ->pupulate() takes this argument, because the handlers of > this callback always call cgroup_add_file()/cgroup_add_files(). > > So we reduce a few lines of code, though the shrinking of object size > is minimal. > > 16 files changed, 113 insertions(+), 162 deletions(-) > > text data bss dec hex filename > 5486240 656987 7039960 13183187 c928d3 vmlinux.o.orig > 5486170 656987 7039960 13183117 c9288d vmlinux.o > > Signed-off-by: Li Zefan Nice cleanup, applied to cgroup/for-3.4. Thank you! -- tejun -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932473Ab2BBR0V (ORCPT ); Thu, 2 Feb 2012 12:26:21 -0500 Received: from mail-iy0-f174.google.com ([209.85.210.174]:36117 "EHLO mail-iy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932340Ab2BBR0R (ORCPT ); Thu, 2 Feb 2012 12:26:17 -0500 Date: Thu, 2 Feb 2012 09:26:11 -0800 From: Tejun Heo To: Li Zefan Cc: LKML , container cgroup , Cgroups , linux-mm@kvack.org, netdev Subject: Re: [PATCH] cgroup: remove cgroup_subsys argument from callbacks Message-ID: <20120202172611.GF19837@google.com> References: <4F278078.5030703@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4F278078.5030703@cn.fujitsu.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 31, 2012 at 01:47:36PM +0800, Li Zefan wrote: > The argument is not used at all, and it's not necessary, because > a specific callback handler of course knows which subsys it > belongs to. > > Now only ->pupulate() takes this argument, because the handlers of > this callback always call cgroup_add_file()/cgroup_add_files(). > > So we reduce a few lines of code, though the shrinking of object size > is minimal. > > 16 files changed, 113 insertions(+), 162 deletions(-) > > text data bss dec hex filename > 5486240 656987 7039960 13183187 c928d3 vmlinux.o.orig > 5486170 656987 7039960 13183117 c9288d vmlinux.o > > Signed-off-by: Li Zefan Nice cleanup, applied to cgroup/for-3.4. Thank you! -- tejun