All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Henrik Rydberg" <rydberg@euromail.se>
To: Chase Douglas <chasedouglas@gmail.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] Input: Add EVIOC mechanism for MT slots
Date: Fri, 3 Feb 2012 08:27:25 +0100	[thread overview]
Message-ID: <20120203072725.GA6914@polaris.bitmath.org> (raw)
In-Reply-To: <4F2B24AC.1020408@gmail.com>

Hi Chase,

> > +#define INPUT_MT_REQUEST(num_slots)					\
> > +	{								\
> > +		__u32 code;						\
> > +		__s32 values[num_slots];				\
> 
> I think this assumes a userspace C compiler that can handle variable
> length arrays. This would require only compiling in C source code at the
> C99 standard or later. It looks like C++ doesn't even allow variable
> length arrays, though gcc handles it. According to:
> 
> http://www.cplusplus.com/forum/beginner/1601/
> 
> it looks like Borland c++ compilers may not be able to compile this :(.

This is resolved on the preprocessor level, so C99 or not does not
enter the problem. Compile-time constant, as you can see in the code
example in the patch summary.

Thanks,
Henrik

  reply	other threads:[~2012-02-03  7:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-31 19:00 [PATCH v3] Input: Add EVIOC mechanism for MT slots Henrik Rydberg
2012-02-03  0:05 ` Chase Douglas
2012-02-03  7:27   ` Henrik Rydberg [this message]
2012-02-04 18:21     ` Chase Douglas
2012-02-05  7:59       ` Henrik Rydberg
2012-02-05 17:13         ` Chase Douglas
2012-02-05 19:40           ` Henrik Rydberg
2012-02-05 22:55             ` Chase Douglas
2012-02-06  7:25               ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120203072725.GA6914@polaris.bitmath.org \
    --to=rydberg@euromail.se \
    --cc=chasedouglas@gmail.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.