All of lore.kernel.org
 help / color / mirror / Atom feed
From: greg@kroah.com (Greg KH)
To: kernelnewbies@lists.kernelnewbies.org
Subject: How to create patch for checkpatch.pl cleanups
Date: Sun, 5 Feb 2012 14:51:37 -0800	[thread overview]
Message-ID: <20120205225137.GA17038@kroah.com> (raw)
In-Reply-To: <CAEnQRZCrtQC-70ksuxpJuETALJ_=i=6sq4nKJDW6vaUS63tksQ@mail.gmail.com>

On Sun, Feb 05, 2012 at 11:10:29PM +0200, Daniel Baluta wrote:
> On Sun, Feb 5, 2012 at 11:00 PM, kashyap gada <kashyapgada@yahoo.com> wrote:
> > Hello Linux Newbies, I'm one too. I was looking out for some clean up work
> > and I ran the checkpatch.pl script. I came across a file with some 400
> > errors and 200 warnings. Now there were bunch of 80 char per line warning ,
> > braces and related things. I don't want to be sending patches for each and
> > every error or warning I fix as it becomes tedious and If i send lots of
> > correction patches in one go the kernel maintainers wont accept it. I want
> > to know Can we correct all similar errors or warnings in one patch? or
> > series of patches?
> 
> Regarding 80 chars per line issues, people are discussing right now
> on increasing the limit to 100. See [1].
> 
> For the other issues, just send a patch with all the changes. It should
> be fine since you are modifying one single file.

No, please break it up into "one thing per patch" to make it easy to
review, otherwise it will be ignored and/or rejected.

Also realize that a lot of subsystem maintainers do not like these types
of patches, outside of the drivers/staging/ area, so you might want to
ask the subsystem developers if they will take this type of work before
you do it.

greg k-h

  reply	other threads:[~2012-02-05 22:51 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <4F2EEC4D.8040403@gmail.com>
     [not found] ` <4F2EED9F.3020803@gmail.com>
2012-02-05 21:00   ` How to create patch for checkpatch.pl cleanups kashyap gada
2012-02-05 21:07     ` How to use /proc Surenkumar Nihalani
2012-02-05 21:20       ` Daniel Baluta
2012-02-05 22:14         ` Surenkumar Nihalani
2012-02-05 22:37           ` Anuz Pratap Singh Tomar
2012-02-05 22:52           ` Greg KH
2012-02-05 21:10     ` How to create patch for checkpatch.pl cleanups Daniel Baluta
2012-02-05 22:51       ` Greg KH [this message]
2012-02-05 23:26         ` kashyap gada
2012-02-06  1:22           ` Greg KH
2012-02-06 11:56           ` Bernd Petrovitsch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120205225137.GA17038@kroah.com \
    --to=greg@kroah.com \
    --cc=kernelnewbies@lists.kernelnewbies.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.