From: Ted Ts'o <tytso@mit.edu>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH] Fix build problems related to profile-directed optimization
Date: Mon, 6 Feb 2012 00:57:50 -0500 [thread overview]
Message-ID: <20120206055750.GA6615@thunk.org> (raw)
In-Reply-To: <20120206041839.GB29365@sigill.intra.peff.net>
On Sun, Feb 05, 2012 at 11:18:39PM -0500, Jeff King wrote:
> > - $ make profile-all
> > - # make prefix=... install
> > + $ make --prefix=/usr PROFILE=BUILD all
> > + # make --prefix=/usr PROFILE=BUILD install
>
> Eh? --prefix?
Oops, configure meme strikes; will fix.
> > +As a caveat: a profile-optimized build takes a *lot* longer since it
> > +is the sources have to be built twice, and in order for the profiling
>
> s/it is//
Thanks, will fix.
> > +ifeq "$(PROFILE)" "GEN"
> > + CFLAGS += -fprofile-generate=$(PROFILE_DIR) -DNO_NORETURN=1
> > + EXTLIBS += -lgcov
> > + export CCACHE_DISABLE=t
> > + V=1
> > +else ifneq "$PROFILE" ""
>
> Did you mean "$(PROFILE)" in the second conditional?
Yes, thanks. Will fix.
- Ted
next prev parent reply other threads:[~2012-02-06 5:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-02 19:03 [PATCH, RFC] Fix build problems related to profile-directed optimization Theodore Ts'o
2012-02-02 20:02 ` Junio C Hamano
2012-02-02 20:12 ` Ted Ts'o
2012-02-02 20:14 ` Ted Ts'o
2012-02-03 0:58 ` Junio C Hamano
2012-02-03 2:07 ` Ted Ts'o
2012-02-03 6:00 ` Junio C Hamano
2012-02-03 18:19 ` Theodore Tso
2012-02-03 19:58 ` Junio C Hamano
2012-02-06 0:44 ` [PATCH] " Theodore Ts'o
2012-02-06 4:18 ` Jeff King
2012-02-06 5:57 ` Ted Ts'o [this message]
2012-02-06 6:00 ` Theodore Ts'o
2012-02-08 18:53 ` Ted Ts'o
2012-02-09 4:03 ` Junio C Hamano
2012-02-09 8:22 ` Johannes Sixt
2012-02-09 18:22 ` Junio C Hamano
2012-02-03 18:39 ` [PATCH, RFC] " Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120206055750.GA6615@thunk.org \
--to=tytso@mit.edu \
--cc=ak@linux.intel.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.