Re: [PATCH 0/2] glib-2.0: Don't check function "qsort_r" in configure.ac

From: Martin Jansa <martin.jansa@gmail.com>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 0/2] glib-2.0: Don't check function "qsort_r" in configure.ac
Date: Mon, 6 Feb 2012 08:05:14 +0100	[thread overview]
Message-ID: <20120206070513.GC3872@jama.jama.net> (raw)
In-Reply-To: <cover.1328509284.git.xiaofeng.yan@windriver.com>

[-- Attachment #1: Type: text/plain, Size: 2141 bytes --]

On Mon, Feb 06, 2012 at 02:41:09PM +0800, Xiaofeng Yan wrote:
> From: Xiaofeng Yan <xiaofeng.yan@windriver.com>
> 
> The function "g_qsort_with_data" has two kinds of realization. One calls qsort_r
> from libglib, the other realize itself. the realization method is controlled by macro "HAVE_QSORT_R".
> qsort_r from libglib cause sort error. Add no-check-qsort_r.patch for fixing this problem.
> This patch is to fix bug 1959. After this patch is merged into OE-core I will open a new bug to
> track the reason why qsort_r report normally. For finishing lsb test in YOCTO 1.2 M3 this patch
> is applied temporarily.
> 
> Pull URL: git://git.pokylinux.org/poky-contrib.git
>   Branch: xiaofeng/1959
>   Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=xiaofeng/1959
> 
> Thanks,
>     Xiaofeng Yan <xiaofeng.yan@windriver.com>
> ---

no-check-qsort_r.patch is the same as remove.test.for.qsort_r.patch from
http://git.openembedded.org/openembedded-core/commit/?id=74f43e3b269c01dba7cd5215a8e825229bd5ecff

which was later removed from glib-2.0-native in
http://git.openembedded.org/openembedded-core/commit/?id=37579d7d74d127c90c1e078d05c5bf4ba0b3f755

and later removed completely in
http://git.openembedded.org/openembedded-core/commit/?id=812342e44e9e361a0fa93cfcfe65cf4dd6f2fb57

Are you sure this patch is right fix? And no need to split adding patch
itself and adding it to SRC_URI to 2 patches.

Cheers,

> 
> 
> Xiaofeng Yan (2):
>   glib-2.0: Don't check function qsort_r
>   glib-2.0: Add patch "no-check-qsort_r.patch"
> 
>  .../glib-2.0/glib-2.0/no-check-qsort_r.patch       |   61 ++++++++++++++++++++
>  meta/recipes-core/glib-2.0/glib-2.0_2.30.2.bb      |    3 +-
>  2 files changed, 63 insertions(+), 1 deletions(-)
>  create mode 100644 meta/recipes-core/glib-2.0/glib-2.0/no-check-qsort_r.patch
> 
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]