From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Liam Girdwood <lrg@ti.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] ASoC: DAPM - Export mixer|mux_update_power() to public API.
Date: Mon, 6 Feb 2012 13:40:25 +0000 [thread overview]
Message-ID: <20120206134025.GI3070@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1328535135-8765-1-git-send-email-lrg@ti.com>
[-- Attachment #1.1: Type: text/plain, Size: 441 bytes --]
On Mon, Feb 06, 2012 at 01:32:15PM +0000, Liam Girdwood wrote:
> +int snd_soc_dapm_mux_update_power(struct snd_soc_dapm_widget *widget,
> + struct snd_kcontrol *kcontrol, int change,
> + int mux, struct soc_enum *e);
We should get rid of the change parameter before exporting this, we've
already got all the conditionals in the callers so it never gets called
without change being set and any users should be doing the same thing.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2012-02-06 13:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-06 13:32 [PATCH] ASoC: DAPM - Export mixer|mux_update_power() to public API Liam Girdwood
2012-02-06 13:40 ` Mark Brown [this message]
2012-02-06 14:24 ` Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120206134025.GI3070@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.