From: Oleg Nesterov <oleg@redhat.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org,
linux-rt-users <linux-rt-users@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Carsten Emde <C.Emde@osadl.org>, John Kacur <jkacur@redhat.com>,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Alexander van Heukelum <heukelum@fastmail.fm>,
Andi Kleen <ak@linux.intel.com>,
Clark Williams <williams@redhat.com>,
Luis Goncalves <lgoncalv@redhat.com>,
stable-rt@vger.kernel.org
Subject: Re: [PATCH RT 2/2 v4] preempt-rt/x86: Delay calling signals in int3
Date: Mon, 6 Feb 2012 17:25:32 +0100 [thread overview]
Message-ID: <20120206162532.GA6951@redhat.com> (raw)
In-Reply-To: <1328544744.2200.11.camel@gandalf.stny.rr.com>
On 02/06, Steven Rostedt wrote:
>
> On Sun, 2012-02-05 at 20:31 +0100, Oleg Nesterov wrote:
> > Damn. Sorry for noise...
> >
> > On 02/05, Oleg Nesterov wrote:
> > >
> > > +int force_sig_info(int sig, struct siginfo *info, struct task_struct *t)
> > > +{
> > > +#ifdef CONFIG_PREEMPT_RT_FULL
> > > + if (in_atomic()) {
> > > + if (WARN_ON_ONCE(t != current))
> >
> > This is certainly wrong in upstream kernel. It does use force_
> > this way although it shouldn't imho.
>
> It's wrong in upstream even with the #ifdef define here?
No, the patch has no effect if !CONFIG_PREEMPT_RT_FULL.
Oleg.
next prev parent reply other threads:[~2012-02-06 16:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-03 18:28 [PATCH RT 0/2 v4] preempt-rt/x86: Handle sending signals from do_trap() by gdb Steven Rostedt
2012-02-03 18:28 ` [PATCH RT 1/2 v4] x86: Do not disable preemption in int3 on 32bit Steven Rostedt
2012-02-03 18:28 ` [PATCH RT 2/2 v4] preempt-rt/x86: Delay calling signals in int3 Steven Rostedt
2012-02-03 18:40 ` Oleg Nesterov
2012-02-03 20:10 ` Steven Rostedt
2012-02-05 19:23 ` Oleg Nesterov
2012-02-05 19:31 ` Oleg Nesterov
2012-02-06 16:12 ` Steven Rostedt
2012-02-06 16:25 ` Oleg Nesterov [this message]
2012-02-06 16:38 ` Steven Rostedt
2012-02-07 14:17 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120206162532.GA6951@redhat.com \
--to=oleg@redhat.com \
--cc=C.Emde@osadl.org \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=heukelum@fastmail.fm \
--cc=hpa@zytor.com \
--cc=jkacur@redhat.com \
--cc=lgoncalv@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=stable-rt@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.