From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: cbou@mail.ru, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Add I2C driver for Summit Microelectronics SMB347 Battery Charger.
Date: Mon, 6 Feb 2012 16:35:45 +0000 [thread overview]
Message-ID: <20120206163544.GO3070@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20120206162409.4f7536cf@pyramind.ukuu.org.uk>
[-- Attachment #1: Type: text/plain, Size: 551 bytes --]
On Mon, Feb 06, 2012 at 04:24:09PM +0000, Alan Cox wrote:
> Mark Brown <broonie@opensource.wolfsonmicro.com> wrote:
> > There's quite a lot of read/modify/write cycles and...
> True but they are basically all in the setup side of things so I'm not
> sure the complexity is justified or appropriate ?
I'm not sure what complexity you mean? If the interface is too
difficult to use we should fix that but I didn't notice anything in the
driver which should be more than a straight substitution (or deletion of
code in the case of the debugfs file).
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-02-06 16:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-06 15:59 [PATCH] Add I2C driver for Summit Microelectronics SMB347 Battery Charger Alan Cox
2012-02-06 16:01 ` Mark Brown
2012-02-06 16:24 ` Alan Cox
2012-02-06 16:35 ` Mark Brown [this message]
2012-02-06 17:05 ` Alan Cox
2012-02-06 17:21 ` Mark Brown
2012-03-13 23:46 ` Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120206163544.GO3070@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=cbou@mail.ru \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.