From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 2/2] hfsplus: Add an ioctl to bless files
Date: Mon, 6 Feb 2012 19:32:56 +0000 [thread overview]
Message-ID: <20120206193256.GA4064@srcf.ucam.org> (raw)
In-Reply-To: <20120206174943.GA14225@infradead.org>
On Mon, Feb 06, 2012 at 12:49:43PM -0500, Christoph Hellwig wrote:
> On Mon, Feb 06, 2012 at 05:45:49PM +0000, Matthew Garrett wrote:
> > On Mon, Feb 06, 2012 at 12:35:53PM -0500, Christoph Hellwig wrote:
> > > +#define HFSPLUS_IOC_BLESS _IO('f', 0x20)
> > >
> > > I'd probably move this to fs.h and follow the numbering there,
> > > otherwise we are bound to run into conflicts.
> >
> > Ok. Any problem with leaving something filesystem specific in there?
>
> Leaving it in hfsplus sounds fine, but I'd avoid using 'f' then just to
> reduce the chance for overlap.
Using the same range but putting it in a different file seems like a
good way to have someone miss it. I added the range to ioctl-list.txt so
in theory nobody should step on it - do you think that's likely to be
inadequate?
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2012-02-06 19:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-02 20:39 [PATCH V2 1/2] hfsplus: Change finder_info to u32 Matthew Garrett
2012-02-02 20:39 ` [PATCH V2 2/2] hfsplus: Add an ioctl to bless files Matthew Garrett
2012-02-06 17:35 ` Christoph Hellwig
2012-02-06 17:45 ` Matthew Garrett
2012-02-06 17:49 ` Christoph Hellwig
2012-02-06 19:32 ` Matthew Garrett [this message]
2012-02-06 20:14 ` [PATCH V2] " Matthew Garrett
2012-02-07 13:25 ` Christoph Hellwig
2012-02-08 8:47 ` Henrik Rydberg
2012-02-06 17:31 ` [PATCH V2 1/2] hfsplus: Change finder_info to u32 Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120206193256.GA4064@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.