From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 2/2 v2] drm/i915: catch gtfifo errors on
 forcewake_put
Date: Tue, 7 Feb 2012 10:32:51 +0100
Message-ID: <20120207093251.GC4118@phenom.ffwll.local>
References: <1328308301-28304-1-git-send-email-ben@bwidawsk.net>
	<1328384923-2688-1-git-send-email-ben@bwidawsk.net>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-ww0-f43.google.com (mail-ww0-f43.google.com [74.125.82.43])
	by gabe.freedesktop.org (Postfix) with ESMTP id 686A39EF75
	for <intel-gfx@lists.freedesktop.org>;
	Tue,  7 Feb 2012 01:32:44 -0800 (PST)
Received: by wgbdr13 with SMTP id dr13so5692805wgb.12
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 07 Feb 2012 01:32:43 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <1328384923-2688-1-git-send-email-ben@bwidawsk.net>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Ben Widawsky <ben@bwidawsk.net>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Sat, Feb 04, 2012 at 11:48:43AM -0800, Ben Widawsky wrote:
> This is similar to a patch I wrote several months ago. It's been updated
> for the new FORCEWAKE_MT, and it also no longer clears the debug
> register as it may be helpful to get that for the error state.  Also
> recommended by Chris Wilson, use WARN() instead of DRM_ERROR, so we can
> get a backtrace.
> 
> v2: replace POSTING_READ with I915_READ_NOTRACE(GTFIFODBG). Recommended
> by Chris Wilson
> 
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Ben Widawsky <ben@bwidawsk.net>

Looks good and because we can drop the posting read it shouldn't have any
perf impact. But we're not checking anything on the write side, which is
actually used the most under normal gem loads (tail updates). Because the
write path is rather perf critical, I think we should only check for
errors in the gt fifo reg if the wait_for_fifo times out. Can you whip up
that patch, too?

Thanks, Daniel
-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48