From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olaf Hering <olaf@aepfle.de>
Subject: Re: [PATCH 1/4] tools/flask: remove libflask
Date: Tue, 7 Feb 2012 11:44:46 +0100
Message-ID: <20120207104446.GA31244@aepfle.de>
References: <1328281981-17399-1-git-send-email-dgdegra@tycho.nsa.gov>
	<1328281981-17399-2-git-send-email-dgdegra@tycho.nsa.gov>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
Content-Disposition: inline
In-Reply-To: <1328281981-17399-2-git-send-email-dgdegra@tycho.nsa.gov>
List-Unsubscribe: <http://lists.xensource.com/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Daniel De Graaf <dgdegra@tycho.nsa.gov>
Cc: xen-devel@lists.xensource.com, keir@xen.org, Ian.Campbell@citrix.com
List-Id: xen-devel@lists.xenproject.org

On Fri, Feb 03, Daniel De Graaf wrote:

> This library has been deprecated since July 2010; remove the in-tree
> users and library.

> -	ln -sf libflask.so.$(MAJOR) $(DESTDIR)$(LIBDIR)/libflask.so

> +++ b/tools/python/setup.py
> @@ -48,7 +48,7 @@ flask = Extension("flask",
>                 include_dirs       = [ PATH_XEN, PATH_LIBXC, "xen/lowlevel/flask",
>                                        "../flask/libflask/include" ],
>                 library_dirs       = [ PATH_LIBXC, "../flask/libflask" ],
> -               libraries          = [ "xenctrl", "flask" ],
> +               libraries          = [ "xenctrl" ],
>                 depends            = [ PATH_LIBXC + "/libxenctrl.so",
>                                        XEN_ROOT + "/tools/flask/libflask/libflask.so" ],
>                 sources            = [ "xen/lowlevel/flask/flask.c" ])


For some reason this changeset does not cause buildfailures in automated
testing. My xen-unstable rpm packages fail to build in SLES11, but not in
openSuSE for some reason.

Is there a chance that libflask.so is built after this python thing runs?
In other words: Is there a makefile dependency missing?

Olaf

...
building 'flask' extension
error: ../../tools/flask/libflask/libflask.so: No such file or directory
make[3]: *** [install] Error 1
make[3]: Leaving directory `/usr/src/packages/BUILD/xen-4.2.24701/non-dbg/tools/python'
make[2]: *** [subdir-install-python] Error 2
...