From mboxrd@z Thu Jan 1 00:00:00 1970 From: 'Greg Kroah-Hartman' Subject: Re: [PATCH 2/3] USB: SET SEL request definition Date: Tue, 7 Feb 2012 08:21:02 -0800 Message-ID: <20120207162102.GC6460@kroah.com> References: <001301cce564$cfa2e030$6ee8a090$%tikhomirov@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <001301cce564$cfa2e030$6ee8a090$%tikhomirov-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Anton Tikhomirov Cc: linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, 'Kukjin Kim' , 'Felipe Balbi' , 'Yulgon Kim' , 'Kyoungil Kim' List-Id: linux-samsung-soc@vger.kernel.org On Tue, Feb 07, 2012 at 03:50:42PM +0900, Anton Tikhomirov wrote: > Hi, > > Greg KH wrote: > > On Mon, Feb 06, 2012 at 05:12:33PM +0900, Anton Tikhomirov wrote: > > > Cc: Kukjin Kim samsung.com> > > > Cc: Greg Kroah-Hartman suse.de> > > > Cc: Felipe Balbi ti.com> > > > > What is that mess? It belongs, with real email addresses, below your > > signed-off-by line, if at all. > > > > > Adds SET SEL standard request definition as defined by ch9 > > > of the USB3.0 specification. > > > > > > Signed-off-by: Anton Tikhomirov > > > --- > > > include/linux/usb/ch9.h | 1 + > > > 1 files changed, 1 insertions(+), 0 deletions(-) > > > > > > diff --git a/include/linux/usb/ch9.h b/include/linux/usb/ch9.h > > > index 61b2905..76ff771 100644 > > > --- a/include/linux/usb/ch9.h > > > +++ b/include/linux/usb/ch9.h > > > @@ -88,6 +88,7 @@ > > > #define USB_REQ_GET_INTERFACE 0x0A > > > #define USB_REQ_SET_INTERFACE 0x0B > > > #define USB_REQ_SYNCH_FRAME 0x0C > > > +#define USB_REQ_SET_SEL 0x30 > > > > > > #define USB_REQ_SET_ENCRYPTION 0x0D /* Wireless USB */ > > > #define USB_REQ_GET_ENCRYPTION 0x0E > > > > Why did you insert this out of order? > > > > greg "please note my email address change as well" k-h > > 'Set SEL' is a standard device request according to USB3.0 spec. > Wireless USB requests are not mentioned in USB3.0 spec (and moreover > are not in ch9 of it). Their requests are part of the wireless USB spec, a different document. > So I put the definition to an appropriate group in my opinion. If you > insist I will move the definition below Wireless USB group with a > space between. Putting them in order would make more sense, thanks. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html