All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: "Reddy, MR Swami" <MR.Swami.Reddy@ti.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	"Girdwood, Liam" <lrg@ti.com>
Subject: Re: [PATCH v3] ASoC: Add support for TI LM49453 Audio codec
Date: Tue, 7 Feb 2012 17:04:05 +0000	[thread overview]
Message-ID: <20120207170405.GA15929@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <290463D19D2E064191F1F96ECA480A89434ABCB420@EXMAIL02.scwf.nsc.com>

On Mon, Feb 06, 2012 at 06:20:26AM -0800, Reddy, MR Swami wrote:

> Changes made in v3:
> o Updated the lm49453_set_dai_pll() as per review comments in v2 patch.
>     o Removed pll disable code in _set_dai_pll().

This doesn't really seem to address the issue at all - you still have
the problems with the set_pll() function not doing anything it's
supposed to do with the input and output frequencies, and now there's no
way to disable the PLL.

           reply	other threads:[~2012-02-07 17:04 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <290463D19D2E064191F1F96ECA480A89434ABCB420@EXMAIL02.scwf.nsc.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120207170405.GA15929@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=MR.Swami.Reddy@ti.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=lrg@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.