From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] repair: fix incorrect use of thread local data in dir and attr code
Date: Wed, 8 Feb 2012 15:13:53 +1100 [thread overview]
Message-ID: <20120208041353.GC20305@dastard> (raw)
In-Reply-To: <20120207175400.GA24301@infradead.org>
On Tue, Feb 07, 2012 at 12:54:00PM -0500, Christoph Hellwig wrote:
> The attribute and dirv1 code use pthread thread local data incorrectly in
> a few places, which will make them fail in horrible ways when using the
> ag_stride options.
>
> Replace the use of thread local data with simple local allocations given
> that there is no needed to micro-optimize these allocations as much
> as e.g. the extent map. The added benefit is that we have to allocate
> less memory, and can free it quickly.
>
> Reported-by: Tom Crane <T.Crane@rhul.ac.uk>
> Tested-by: Tom Crane <T.Crane@rhul.ac.uk>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Looks pretty sane to me. Especially as the comments suggest it never
even worked correctly in the first place.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2012-02-08 4:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-07 17:54 [PATCH] repair: fix incorrect use of thread local data in dir and attr code Christoph Hellwig
2012-02-08 4:13 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120208041353.GC20305@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.