Re: [PATCH] kmsg_dump: Don't run on non-error paths by default

[Matthew Garrett <mjg@redhat.com>]

On Wed, Feb 08, 2012 at 11:30:07AM -0500, Vivek Goyal wrote:

> > +	if (reason > KMSG_DUMP_PANIC && !always_kmsg_dump)
> > +		return;
> 
> Did you mean reason > KMSG_DUMP_OOPS to enable oops logging by default?

Bah. Yes, I think my test system was set to panic on oops so I didn't 
catch that.

> Given the fact that not everybody likes kmsg_dump() and it is not known
> how stable it with various backends, will it make sense to keep it disabled
> by default and provide a knob to enable it (instead of always_kmsg_dump).

I think logging panics and oopses by default is a useful feature. It may 
be desirable to have a mechanism to disable it if some other way of 
handling that (serial console, kdump) is available.

-- 
Matthew Garrett | mjg59@srcf.ucam.org