From: Matthew Garrett <mjg59@srcf.ucam.org>
To: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
Cc: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: [PATCH 2/4] Add grub_efi_get_variable
Date: Wed, 8 Feb 2012 20:19:11 +0000 [thread overview]
Message-ID: <20120208201911.GA8098@srcf.ucam.org> (raw)
In-Reply-To: <4F32D673.2070402@gmail.com>
On Wed, Feb 08, 2012 at 09:09:23PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
> On 08.02.2012 21:04, Matthew Garrett wrote:
> >On Wed, Feb 08, 2012 at 08:55:39PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
> >>>+ for (i=0; i<(int)grub_strlen((char *)var); i++)
> >>>+ var16[i] = var[i];
> >>>+ var16[i] = '\0';
> >>>+
> >>We use grub_utf8_to_utf16. Also don't forget to multiply the malloc
> >>length by GRUB_MAX_UTF16_PER_UTF8 ((GRUB_MAX_UTF16_PER_UTF8 * length
> >>+ 1) * sizeof (var16[0]))
> >That's not currently exported. Any problem with changing that?
> It already is. The prototype and the define is in grub/charset.h
Oh, I was thinking of modules, but then this is already in core. Yes,
I'll do that.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2012-02-08 20:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-08 16:51 Some improvements to EFI GOP support Matthew Garrett
2012-02-08 16:51 ` [PATCH 1/4] Add PCI protocols Matthew Garrett
2012-02-08 19:51 ` Vladimir 'φ-coder/phcoder' Serbinenko
2012-02-08 16:51 ` [PATCH 2/4] Add grub_efi_get_variable Matthew Garrett
2012-02-08 19:55 ` Vladimir 'φ-coder/phcoder' Serbinenko
2012-02-08 20:04 ` Matthew Garrett
2012-02-08 20:09 ` Vladimir 'φ-coder/phcoder' Serbinenko
2012-02-08 20:19 ` Matthew Garrett [this message]
2012-02-08 20:29 ` Vladimir 'φ-coder/phcoder' Serbinenko
2012-02-08 16:51 ` [PATCH 3/4] Prefer GOP devices which implement the pci_io protocol Matthew Garrett
2012-02-08 19:59 ` Vladimir 'φ-coder/phcoder' Serbinenko
2012-02-08 16:51 ` [PATCH 4/4] Add support for getting EDID via EFI Matthew Garrett
2012-02-08 20:07 ` Vladimir 'φ-coder/phcoder' Serbinenko
2012-02-08 17:02 ` Some improvements to EFI GOP support Keshav P R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120208201911.GA8098@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=grub-devel@gnu.org \
--cc=phcoder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.