All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Graham <simon.graham@virtualcomputer.com>
To: linux-wireless@vger.kernel.org
Cc: linville@tuxdriver.com, Larry.Finger@lwfinger.net,
	chaoming_li@realsil.com.cn
Subject: [PATCH V2] rtlwifi: Return correct failure code on error
Date: Wed, 8 Feb 2012 16:14:36 -0500	[thread overview]
Message-ID: <20120208211436.GA1309@simgr-precise.oldroadcomputing.net> (raw)

Callers of rtl_pci_init expect zero to be returned on error. Returning
the error code leads to the data being used when it shouldn't causing,
amongst other things, divide by zero panics attempting to use the
ring size that is set to zero.

Signed-off-by: Simon Graham <simon.graham@virtualcomputer.com>
---
 drivers/net/wireless/rtlwifi/pci.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/wireless/rtlwifi/pci.c b/drivers/net/wireless/rtlwifi/pci.c
index fb84707..f0ce366 100644
--- a/drivers/net/wireless/rtlwifi/pci.c
+++ b/drivers/net/wireless/rtlwifi/pci.c
@@ -1492,7 +1492,7 @@ static int rtl_pci_init(struct ieee80211_hw *hw, struct pci_dev *pdev)
 	if (err) {
 		RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG,
 			 "tx ring initialization failed\n");
-		return err;
+		return 0;
 	}
 
 	return 1;
-- 
1.7.8.3


             reply	other threads:[~2012-02-08 21:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-08 21:14 Simon Graham [this message]
2012-02-09  1:59 ` [PATCH V2] rtlwifi: Return correct failure code on error Larry Finger
2012-02-09  2:18   ` Simon Graham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120208211436.GA1309@simgr-precise.oldroadcomputing.net \
    --to=simon.graham@virtualcomputer.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=chaoming_li@realsil.com.cn \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.